Re: [PATCH] hw/net/can: Add missing fallthrough statements

2020-07-13 Thread Pavel Pisa
Hello Laurent and others, On Monday 06 of July 2020 18:35:50 Laurent Vivier wrote: > Le 30/06/2020 à 09:55, Thomas Huth a écrit : > > Add fallthrough annotations to be able to compile the code without > > warnings when using -Wimplicit-fallthrough in our CFLAGS. Looking > > at the code, it seems

Re: [PATCH] hw/net/can: Add missing fallthrough statements

2020-07-06 Thread Laurent Vivier
Le 30/06/2020 à 09:55, Thomas Huth a écrit : > Add fallthrough annotations to be able to compile the code without > warnings when using -Wimplicit-fallthrough in our CFLAGS. Looking > at the code, it seems like the fallthrough is indeed intended here, > so the comments should be appropriate. > >

[PATCH] hw/net/can: Add missing fallthrough statements

2020-06-30 Thread Thomas Huth
Add fallthrough annotations to be able to compile the code without warnings when using -Wimplicit-fallthrough in our CFLAGS. Looking at the code, it seems like the fallthrough is indeed intended here, so the comments should be appropriate. Signed-off-by: Thomas Huth --- hw/net/can/can_sja1000.c