Re: [PATCH] target/arm: Display helpful message when hflags mismatch

2019-12-17 Thread Philippe Mathieu-Daudé
On 12/17/19 5:08 PM, Peter Maydell wrote: On Tue, 17 Dec 2019 at 16:02, Richard Henderson wrote: On Mon, 9 Dec 2019 at 03:46, Philippe Mathieu-Daudé wrote: Instead of crashing in a confuse way, give some hint to the user about why we aborted. He might report the issue without having to use

Re: [PATCH] target/arm: Display helpful message when hflags mismatch

2019-12-17 Thread Peter Maydell
On Tue, 17 Dec 2019 at 16:02, Richard Henderson wrote: > > On Mon, 9 Dec 2019 at 03:46, Philippe Mathieu-Daudé wrote: > > > > Instead of crashing in a confuse way, give some hint to the user > > about why we aborted. He might report the issue without having > > to use a debugger. > > > >

Re: [PATCH] target/arm: Display helpful message when hflags mismatch

2019-12-17 Thread Richard Henderson
On Mon, 9 Dec 2019 at 03:46, Philippe Mathieu-Daudé wrote: > > Instead of crashing in a confuse way, give some hint to the user > about why we aborted. He might report the issue without having > to use a debugger. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/arm/helper.c | 18

Re: [PATCH] target/arm: Display helpful message when hflags mismatch

2019-12-14 Thread Philippe Mathieu-Daudé
On 12/12/19 1:36 AM, Richard Henderson wrote: On 12/9/19 8:00 AM, Alex Bennée wrote: -#ifdef CONFIG_DEBUG_TCG -assert(flags == rebuild_hflags_internal(env)); -#endif +assert_hflags_rebuild_correctly(env); I'm trying to recall why we don't just use: g_assert_cmphex(flags, =,

Re: [PATCH] target/arm: Display helpful message when hflags mismatch

2019-12-11 Thread Richard Henderson
On 12/9/19 8:00 AM, Alex Bennée wrote: >> -#ifdef CONFIG_DEBUG_TCG >> -assert(flags == rebuild_hflags_internal(env)); >> -#endif >> +assert_hflags_rebuild_correctly(env); > > I'm trying to recall why we don't just use: > > g_assert_cmphex(flags, =, rebuild_hflags_internal(env)) > > I

Re: [PATCH] target/arm: Display helpful message when hflags mismatch

2019-12-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191209134552.27733-1-phi...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [PATCH] target/arm: Display helpful message when hflags mismatch

2019-12-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191209134552.27733-1-phi...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [PATCH] target/arm: Display helpful message when hflags mismatch

2019-12-09 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Instead of crashing in a confuse way, give some hint to the user > about why we aborted. He might report the issue without having > to use a debugger. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/arm/helper.c | 18 +++--- > 1 file

[PATCH] target/arm: Display helpful message when hflags mismatch

2019-12-09 Thread Philippe Mathieu-Daudé
Instead of crashing in a confuse way, give some hint to the user about why we aborted. He might report the issue without having to use a debugger. Signed-off-by: Philippe Mathieu-Daudé --- target/arm/helper.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git