Re: [PATCH] target/i386: skip kvm_msr_entry_add when kvm_vmx_basic is 0

2019-12-06 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1575627817-24625-1-git-send-email-catherine.h...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH] target/i386: skip kvm_msr_entry_add when kvm_vmx_basic is 0 Type: series Message

[PATCH] target/i386: skip kvm_msr_entry_add when kvm_vmx_basic is 0

2019-12-06 Thread Catherine Ho
Commit 1389309c811b ("KVM: nVMX: expose VMX capabilities for nested hypervisors to userspace") expands the msr_based_features with MSR_IA32_VMX_BASIC and others. Then together with an old kernel before 1389309c811b, the qemu call KVM_GET_MSR_FEATURE_INDEX_LIST and got the smaller kvm_feature_msrs.

Re: [PATCH] target/i386: skip kvm_msr_entry_add when kvm_vmx_basic is 0

2019-12-06 Thread Paolo Bonzini
On 06/12/19 11:23, Catherine Ho wrote: > Commit 1389309c811b ("KVM: nVMX: expose VMX capabilities for nested > hypervisors to userspace") expands the msr_based_features with > MSR_IA32_VMX_BASIC and others. Then together with an old kernel before > 1389309c811b, the qemu call

Re: [PATCH] target/i386: skip kvm_msr_entry_add when kvm_vmx_basic is 0

2019-12-06 Thread Catherine Ho
Hi Paolo and Eduardo I digged into the put msr assertion bug a little more, and seems I found the root cause. Please have a review. Best regards. Catherine On Fri, 6 Dec 2019 at 18:25, Catherine Ho wrote: > > Commit 1389309c811b ("KVM: nVMX: expose VMX capabilities for nested > hypervisors to