Re: [PATCH-for-10.1 v7 4/8] qemu/target-info: Add target_endian_mode()

[Philippe Mathieu-Daudé]

On 8/7/25 19:36, Richard Henderson wrote:

On 7/8/25 11:19, Philippe Mathieu-Daudé wrote:

+/**
+ * target_endian_mode:
+ *
+ * Returns: QAPI EndianMode enum (i.e. ENDIAN_MODE_LITTLE).


s/i.e./e.g./


TIL i.e. vs e.g. :)



Otherwise,
Reviewed-by: Richard Henderson 


r~

Re: [PATCH-for-10.1 v7 4/8] qemu/target-info: Add target_endian_mode()

[Richard Henderson]

On 7/8/25 11:19, Philippe Mathieu-Daudé wrote:

+/**
+ * target_endian_mode:
+ *
+ * Returns: QAPI EndianMode enum (i.e. ENDIAN_MODE_LITTLE).


s/i.e./e.g./

Otherwise,
Reviewed-by: Richard Henderson 


r~

Re: [PATCH-for-10.1 v7 4/8] qemu/target-info: Add target_endian_mode()

[Pierrick Bouvier]

On 7/8/25 10:19 AM, Philippe Mathieu-Daudé wrote:

target_endian_mode() returns the default endianness (QAPI type)
of a target.

Signed-off-by: Philippe Mathieu-Daudé 
---
  include/qemu/target-info-impl.h | 2 ++
  include/qemu/target-info-qapi.h | 8 
  target-info-stub.c  | 1 +
  target-info.c   | 5 +
  4 files changed, 16 insertions(+)


Reviewed-by: Pierrick Bouvier 

[PATCH-for-10.1 v7 4/8] qemu/target-info: Add target_endian_mode()

[Philippe Mathieu-Daudé]

target_endian_mode() returns the default endianness (QAPI type)
of a target.

Signed-off-by: Philippe Mathieu-Daudé 
---
 include/qemu/target-info-impl.h | 2 ++
 include/qemu/target-info-qapi.h | 8 
 target-info-stub.c  | 1 +
 target-info.c   | 5 +
 4 files changed, 16 insertions(+)

diff --git a/include/qemu/target-info-impl.h b/include/qemu/target-info-impl.h
index a8b34d150ab..17887f64e26 100644
--- a/include/qemu/target-info-impl.h
+++ b/include/qemu/target-info-impl.h
@@ -22,6 +22,8 @@ typedef struct TargetInfo {
 const char *cpu_type;
 /* QOM typename machines for this binary must implement */
 const char *machine_typename;
+/* related to TARGET_BIG_ENDIAN definition */
+EndianMode endianness;
 } TargetInfo;
 
 /**
diff --git a/include/qemu/target-info-qapi.h b/include/qemu/target-info-qapi.h
index dae92c47eb1..bdf207e6a3e 100644
--- a/include/qemu/target-info-qapi.h
+++ b/include/qemu/target-info-qapi.h
@@ -9,6 +9,7 @@
 #ifndef QEMU_TARGET_INFO_EXTRA_H
 #define QEMU_TARGET_INFO_EXTRA_H
 
+#include "qapi/qapi-types-common.h"
 #include "qapi/qapi-types-machine.h"
 
 /**
@@ -18,4 +19,11 @@
  */
 SysEmuTarget target_arch(void);
 
+/**
+ * target_endian_mode:
+ *
+ * Returns: QAPI EndianMode enum (i.e. ENDIAN_MODE_LITTLE).
+ */
+EndianMode target_endian_mode(void);
+
 #endif
diff --git a/target-info-stub.c b/target-info-stub.c
index 2e4407ff04b..ca0caa3686c 100644
--- a/target-info-stub.c
+++ b/target-info-stub.c
@@ -18,6 +18,7 @@ static const TargetInfo target_info_stub = {
 .long_bits = TARGET_LONG_BITS,
 .cpu_type = CPU_RESOLVING_TYPE,
 .machine_typename = TYPE_MACHINE,
+.endianness = TARGET_BIG_ENDIAN ? ENDIAN_MODE_BIG : ENDIAN_MODE_LITTLE,
 };
 
 const TargetInfo *target_info(void)
diff --git a/target-info.c b/target-info.c
index 8e29553b4ef..a756c0714c4 100644
--- a/target-info.c
+++ b/target-info.c
@@ -42,3 +42,8 @@ const char *target_machine_typename(void)
 {
 return target_info()->machine_typename;
 }
+
+EndianMode target_endian_mode(void)
+{
+return target_info()->endianness;
+}
-- 
2.49.0