Re: [PATCH-for-5.2] target/mips: Report unimplemented cache() operations

2020-08-13 Thread Philippe Mathieu-Daudé
On 8/13/20 5:23 PM, Jiaxun Yang wrote: > 在 2020/8/11 上午1:21, Philippe Mathieu-Daudé 写道: >> On 8/6/20 11:37 PM, Philippe Mathieu-Daudé wrote: >>> On 8/6/20 10:51 PM, Peter Maydell wrote: On Thu, 6 Aug 2020 at 21:31, Philippe Mathieu-Daudé wrote: > On 8/6/20 8:01 PM, Jiaxun Yang wrote:

Re: [PATCH-for-5.2] target/mips: Report unimplemented cache() operations

2020-08-13 Thread Jiaxun Yang
在 2020/8/11 上午1:21, Philippe Mathieu-Daudé 写道: On 8/6/20 11:37 PM, Philippe Mathieu-Daudé wrote: On 8/6/20 10:51 PM, Peter Maydell wrote: On Thu, 6 Aug 2020 at 21:31, Philippe Mathieu-Daudé wrote: On 8/6/20 8:01 PM, Jiaxun Yang wrote: 在 2020/8/6 下午8:26, Philippe Mathieu-Daudé 写道: We only

Re: [PATCH-for-5.2] target/mips: Report unimplemented cache() operations

2020-08-13 Thread Jiaxun Yang
在 2020/8/11 上午1:21, Philippe Mathieu-Daudé 写道: On 8/6/20 11:37 PM, Philippe Mathieu-Daudé wrote: On 8/6/20 10:51 PM, Peter Maydell wrote: On Thu, 6 Aug 2020 at 21:31, Philippe Mathieu-Daudé wrote: On 8/6/20 8:01 PM, Jiaxun Yang wrote: 在 2020/8/6 下午8:26, Philippe Mathieu-Daudé 写道: We only

Re: [PATCH-for-5.2] target/mips: Report unimplemented cache() operations

2020-08-10 Thread Philippe Mathieu-Daudé
On 8/6/20 11:37 PM, Philippe Mathieu-Daudé wrote: > On 8/6/20 10:51 PM, Peter Maydell wrote: >> On Thu, 6 Aug 2020 at 21:31, Philippe Mathieu-Daudé wrote: >>> >>> On 8/6/20 8:01 PM, Jiaxun Yang wrote: 在 2020/8/6 下午8:26, Philippe Mathieu-Daudé 写道: > We only implement the Index[Store/Load]T

Re: [PATCH-for-5.2] target/mips: Report unimplemented cache() operations

2020-08-07 Thread Jiaxun Yang
在 2020/8/7 上午4:51, Peter Maydell 写道: On Thu, 6 Aug 2020 at 21:31, Philippe Mathieu-Daudé wrote: On 8/6/20 8:01 PM, Jiaxun Yang wrote: 在 2020/8/6 下午8:26, Philippe Mathieu-Daudé 写道: We only implement the Index[Store/Load]Tag from the 'cache' opcode. Instead of ignoring the other cache operat

Re: [PATCH-for-5.2] target/mips: Report unimplemented cache() operations

2020-08-06 Thread Philippe Mathieu-Daudé
On 8/6/20 10:51 PM, Peter Maydell wrote: > On Thu, 6 Aug 2020 at 21:31, Philippe Mathieu-Daudé wrote: >> >> On 8/6/20 8:01 PM, Jiaxun Yang wrote: >>> 在 2020/8/6 下午8:26, Philippe Mathieu-Daudé 写道: We only implement the Index[Store/Load]Tag from the 'cache' opcode. Instead of ignoring the

Re: [PATCH-for-5.2] target/mips: Report unimplemented cache() operations

2020-08-06 Thread Peter Maydell
On Thu, 6 Aug 2020 at 21:31, Philippe Mathieu-Daudé wrote: > > On 8/6/20 8:01 PM, Jiaxun Yang wrote: > > 在 2020/8/6 下午8:26, Philippe Mathieu-Daudé 写道: > >> We only implement the Index[Store/Load]Tag from the 'cache' opcode. > >> Instead of ignoring the other cache operations, report them as > >> u

Re: [PATCH-for-5.2] target/mips: Report unimplemented cache() operations

2020-08-06 Thread Philippe Mathieu-Daudé
On 8/6/20 8:01 PM, Jiaxun Yang wrote: > 在 2020/8/6 下午8:26, Philippe Mathieu-Daudé 写道: >> We only implement the Index[Store/Load]Tag from the 'cache' opcode. >> Instead of ignoring the other cache operations, report them as >> unimplemented. > > Hmm, I don't think we have anything to do with Invali

Re: [PATCH-for-5.2] target/mips: Report unimplemented cache() operations

2020-08-06 Thread Jiaxun Yang
在 2020/8/6 下午8:26, Philippe Mathieu-Daudé 写道: We only implement the Index[Store/Load]Tag from the 'cache' opcode. Instead of ignoring the other cache operations, report them as unimplemented. Hmm, I don't think we have anything to do with Invalidate/Writeback etc. opcodes in QEMU. Why do w

[PATCH-for-5.2] target/mips: Report unimplemented cache() operations

2020-08-06 Thread Philippe Mathieu-Daudé
We only implement the Index[Store/Load]Tag from the 'cache' opcode. Instead of ignoring the other cache operations, report them as unimplemented. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/op_helper.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/mips/op_helper.c b/targ