Re: [PATCH v5 22/22] gdbstub: do not split gdb_monitor_write payload

[Richard Henderson]

On 1/14/20 5:09 AM, Alex Bennée wrote:
> From: Damien Hedde 
> 
> Since we can now send packets of arbitrary length:
> simplify gdb_monitor_write() and send the whole payload
> in one packet.
> 
> Suggested-by: Luc Michel 
> Signed-off-by: Damien Hedde 
> Signed-off-by: Alex Bennée 
> Message-Id: <20191211160514.58373-3-damien.he...@greensocs.com>
> ---
>  gdbstub.c | 23 +++
>  1 file changed, 3 insertions(+), 20 deletions(-)

Reviewed-by: Richard Henderson 


r~

[PATCH v5 22/22] gdbstub: do not split gdb_monitor_write payload

[Alex Bennée]

From: Damien Hedde 

Since we can now send packets of arbitrary length:
simplify gdb_monitor_write() and send the whole payload
in one packet.

Suggested-by: Luc Michel 
Signed-off-by: Damien Hedde 
Signed-off-by: Alex Bennée 
Message-Id: <20191211160514.58373-3-damien.he...@greensocs.com>
---
 gdbstub.c | 23 +++
 1 file changed, 3 insertions(+), 20 deletions(-)

diff --git a/gdbstub.c b/gdbstub.c
index b9fb8c0a95..6e461d871e 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -3200,28 +3200,11 @@ static void gdb_chr_event(void *opaque, QEMUChrEvent 
event)
 }
 }
 
-static void gdb_monitor_output(const char *msg, int len)
-{
-g_autoptr(GString) buf = g_string_new("O");
-memtohex(buf, (uint8_t *)msg, len);
-put_packet(buf->str);
-}
-
 static int gdb_monitor_write(Chardev *chr, const uint8_t *buf, int len)
 {
-const char *p = (const char *)buf;
-int max_sz;
-
-max_sz = (MAX_PACKET_LENGTH / 2) + 1;
-for (;;) {
-if (len <= max_sz) {
-gdb_monitor_output(p, len);
-break;
-}
-gdb_monitor_output(p, max_sz);
-p += max_sz;
-len -= max_sz;
-}
+g_autoptr(GString) hex_buf = g_string_new("O");
+memtohex(hex_buf, buf, len);
+put_packet(hex_buf->str);
 return len;
 }
 
-- 
2.20.1