Re: [PATCH 1/2] block: pass BlockDriver reference to the .bdrv_co_create

2020-03-26 Thread Eric Blake
On 3/26/20 8:22 AM, Maxim Levitsky wrote: On Thu, 2020-03-26 at 08:18 -0500, Eric Blake wrote: On 3/25/20 8:12 PM, Maxim Levitsky wrote: This will allow to reuse a single generic .bdrv_co_create "allow to ${verb}" is not idiomatic, better is "allow ${subject} to ${verb}" or "allow

Re: [PATCH 1/2] block: pass BlockDriver reference to the .bdrv_co_create

2020-03-26 Thread Maxim Levitsky
On Thu, 2020-03-26 at 08:18 -0500, Eric Blake wrote: > On 3/25/20 8:12 PM, Maxim Levitsky wrote: > > This will allow to reuse a single generic .bdrv_co_create > > "allow to ${verb}" is not idiomatic, better is "allow ${subject} to > ${verb}" or "allow ${verb}ing". In this case, I'd go with: >

Re: [PATCH 1/2] block: pass BlockDriver reference to the .bdrv_co_create

2020-03-26 Thread Eric Blake
On 3/25/20 8:12 PM, Maxim Levitsky wrote: This will allow to reuse a single generic .bdrv_co_create "allow to ${verb}" is not idiomatic, better is "allow ${subject} to ${verb}" or "allow ${verb}ing". In this case, I'd go with: This will allow the reuse of a single... implementation for

[PATCH 1/2] block: pass BlockDriver reference to the .bdrv_co_create

2020-03-25 Thread Maxim Levitsky
This will allow to reuse a single generic .bdrv_co_create implementation for several drivers. No functional changes. Signed-off-by: Maxim Levitsky --- block.c | 3 ++- block/crypto.c| 3 ++- block/file-posix.c| 4 +++- block/file-win32.c| 4 +++-