Re: [PATCH 1/2] dp264: use pci_create() to initialise the cmd646 device

2020-02-16 Thread Richard Henderson
On 2/14/20 12:46 AM, Mark Cave-Ayland wrote: > Remove the call to pci_cmd646_ide_init() since global device init functions > are deprecated in preference of using qdev directly. > > Signed-off-by: Mark Cave-Ayland > --- > hw/alpha/dp264.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deleti

Re: [PATCH 1/2] dp264: use pci_create() to initialise the cmd646 device

2020-02-14 Thread Mark Cave-Ayland
On 14/02/2020 11:47, Philippe Mathieu-Daudé wrote: > Hi Mark, > > On Fri, Feb 14, 2020 at 9:48 AM Mark Cave-Ayland > wrote: >> >> Remove the call to pci_cmd646_ide_init() since global device init functions >> are deprecated in preference of using qdev directly. >> >> Signed-off-by: Mark Cave-Ayl

Re: [PATCH 1/2] dp264: use pci_create() to initialise the cmd646 device

2020-02-14 Thread Philippe Mathieu-Daudé
Hi Mark, On Fri, Feb 14, 2020 at 9:48 AM Mark Cave-Ayland wrote: > > Remove the call to pci_cmd646_ide_init() since global device init functions > are deprecated in preference of using qdev directly. > > Signed-off-by: Mark Cave-Ayland > --- > hw/alpha/dp264.c | 8 +++- > 1 file changed, 7

[PATCH 1/2] dp264: use pci_create() to initialise the cmd646 device

2020-02-14 Thread Mark Cave-Ayland
Remove the call to pci_cmd646_ide_init() since global device init functions are deprecated in preference of using qdev directly. Signed-off-by: Mark Cave-Ayland --- hw/alpha/dp264.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/alpha/dp264.c b/hw/alpha/dp264.c ind