Re: [PATCH 17/18] fpu: Add accessors for rebias_{underflow,overflow}

[Philippe Mathieu-Daudé]

On 8/5/26 00:17, Richard Henderson wrote:

Signed-off-by: Richard Henderson 
---
  include/fpu/softfloat-helpers.h | 10 ++
  target/ppc/cpu.c|  4 ++--
  fpu/softfloat-parts.c.inc   |  4 ++--
  fpu/softfloat-specialize.c.inc  | 10 ++
  4 files changed, 24 insertions(+), 4 deletions(-)


Reviewed-by: Philippe Mathieu-Daudé 

[PATCH 17/18] fpu: Add accessors for rebias_{underflow,overflow}

[Richard Henderson]

Signed-off-by: Richard Henderson 
---
 include/fpu/softfloat-helpers.h | 10 ++
 target/ppc/cpu.c|  4 ++--
 fpu/softfloat-parts.c.inc   |  4 ++--
 fpu/softfloat-specialize.c.inc  | 10 ++
 4 files changed, 24 insertions(+), 4 deletions(-)

diff --git a/include/fpu/softfloat-helpers.h b/include/fpu/softfloat-helpers.h
index 49e04ffee9..4791a7fc87 100644
--- a/include/fpu/softfloat-helpers.h
+++ b/include/fpu/softfloat-helpers.h
@@ -131,6 +131,16 @@ static inline void set_snan_rule(FloatSNaNRule val, 
float_status *status)
 status->float_snan_rule = val;
 }
 
+static inline void set_float_rebias_overflow(bool val, float_status *status)
+{
+status->rebias_overflow = val;
+}
+
+static inline void set_float_rebias_underflow(bool val, float_status *status)
+{
+status->rebias_underflow = val;
+}
+
 static inline FloatRoundMode get_float_rounding_mode(const float_status 
*status)
 {
 return status->float_rounding_mode;
diff --git a/target/ppc/cpu.c b/target/ppc/cpu.c
index 4d8faaddee..41edb18643 100644
--- a/target/ppc/cpu.c
+++ b/target/ppc/cpu.c
@@ -248,8 +248,8 @@ void ppc_store_fpscr(CPUPPCState *env, target_ulong val)
 val |= FP_FEX;
 }
 env->fpscr = val;
-env->fp_status.rebias_overflow  = (FP_OE & env->fpscr) ? true : false;
-env->fp_status.rebias_underflow = (FP_UE & env->fpscr) ? true : false;
+set_float_rebias_overflow(FP_OE & env->fpscr, &env->fp_status);
+set_float_rebias_underflow(FP_UE & env->fpscr, &env->fp_status);
 if (tcg_enabled()) {
 fpscr_set_rounding_mode(env);
 }
diff --git a/fpu/softfloat-parts.c.inc b/fpu/softfloat-parts.c.inc
index 5598c8b44a..2198841f05 100644
--- a/fpu/softfloat-parts.c.inc
+++ b/fpu/softfloat-parts.c.inc
@@ -368,7 +368,7 @@ static void partsN(uncanon_normal)(FloatPartsN *p, 
float_status *s,
 switch (fmt->exp_max_kind) {
 case float_expmax_ieee:
 flags |= float_flag_overflow;
-if (s->rebias_overflow) {
+if (get_float_rebias_overflow(s)) {
 exp -= fmt->exp_re_bias;
 } else if (overflow_norm) {
 flags |= float_flag_inexact;
@@ -408,7 +408,7 @@ static void partsN(uncanon_normal)(FloatPartsN *p, 
float_status *s,
 }
 }
 fracN(shr)(p, frac_shift);
-} else if (unlikely(s->rebias_underflow)) {
+} else if (unlikely(get_float_rebias_underflow(s))) {
 flags |= float_flag_underflow;
 exp += fmt->exp_re_bias;
 if (p->frac_lo & round_mask) {
diff --git a/fpu/softfloat-specialize.c.inc b/fpu/softfloat-specialize.c.inc
index fe56cb7c7a..d9bea064e3 100644
--- a/fpu/softfloat-specialize.c.inc
+++ b/fpu/softfloat-specialize.c.inc
@@ -94,6 +94,16 @@ static inline uint8_t get_float_default_nan_pattern(const 
float_status *status)
 return status->default_nan_pattern;
 }
 
+static inline bool get_float_rebias_overflow(const float_status *status)
+{
+return status->rebias_overflow;
+}
+
+static inline bool get_float_rebias_underflow(const float_status *status)
+{
+return status->rebias_underflow;
+}
+
 /*
 | For the deconstructed floating-point with fraction FRAC, return true
 | if the fraction represents a signalling NaN; otherwise false.
-- 
2.43.0