Re: [PATCH 3/4] tests/docker/dockerfiles/debian.docker: add missing apt update
On Tue, Jul 07, 2026 at 02:46:54PM -0700, Pierrick Bouvier wrote: > RUN statements should always use apt update && apt install together: > https://docs.docker.com/build/building/best-practices/#apt-get > > Signed-off-by: Pierrick Bouvier > --- > tests/docker/dockerfiles/debian.docker | 3 ++- > tests/lcitool/refresh | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com ~~https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~https://fstop138.berrange.com :|
[PATCH 3/4] tests/docker/dockerfiles/debian.docker: add missing apt update
RUN statements should always use apt update && apt install together: https://docs.docker.com/build/building/best-practices/#apt-get Signed-off-by: Pierrick Bouvier --- tests/docker/dockerfiles/debian.docker | 3 ++- tests/lcitool/refresh | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/docker/dockerfiles/debian.docker b/tests/docker/dockerfiles/debian.docker index ee8b313d654..413986d3f07 100644 --- a/tests/docker/dockerfiles/debian.docker +++ b/tests/docker/dockerfiles/debian.docker @@ -157,7 +157,8 @@ ENV MAKE="/usr/bin/make" ENV NINJA="/usr/bin/ninja" ENV PYTHON="/usr/bin/python3" # netmap/cscope/global -RUN DEBIAN_FRONTEND=noninteractive eatmydata \ +RUN apt update && \ + DEBIAN_FRONTEND=noninteractive eatmydata \ apt install -y --no-install-recommends \ cscope\ global\ diff --git a/tests/lcitool/refresh b/tests/lcitool/refresh index bbbc6d3c46a..8def84d946e 100755 --- a/tests/lcitool/refresh +++ b/tests/lcitool/refresh @@ -111,7 +111,8 @@ RUN apk add clang19-libclang # test debian13_extras = r""" # netmap/cscope/global -RUN DEBIAN_FRONTEND=noninteractive eatmydata \ +RUN apt update && \ + DEBIAN_FRONTEND=noninteractive eatmydata \ apt install -y --no-install-recommends \ cscope\ global\ -- 2.47.3
