Re: [PATCH 5/8] target/xtensa: Evaluate TARGET_BIG_ENDIAN at compile time

[Richard Henderson]

On 4/17/25 06:10, Philippe Mathieu-Daudé wrote:

Rather than evaluating TARGET_BIG_ENDIAN at preprocessing
time via #ifdef'ry, do it in C at compile time

Signed-off-by: Philippe Mathieu-Daudé
---
  target/xtensa/translate.c | 10 +-
  1 file changed, 5 insertions(+), 5 deletions(-)


Reviewed-by: Richard Henderson 

r~

[PATCH 5/8] target/xtensa: Evaluate TARGET_BIG_ENDIAN at compile time

[Philippe Mathieu-Daudé]

Rather than evaluating TARGET_BIG_ENDIAN at preprocessing
time via #ifdef'ry, do it in C at compile time

Signed-off-by: Philippe Mathieu-Daudé 
---
 target/xtensa/translate.c | 10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/target/xtensa/translate.c b/target/xtensa/translate.c
index 5ebd4a512c9..2af83c07c2e 100644
--- a/target/xtensa/translate.c
+++ b/target/xtensa/translate.c
@@ -1395,11 +1395,11 @@ static void translate_bbi(DisasContext *dc, const 
OpcodeArg arg[],
   const uint32_t par[])
 {
 TCGv_i32 tmp = tcg_temp_new_i32();
-#if TARGET_BIG_ENDIAN
-tcg_gen_andi_i32(tmp, arg[0].in, 0x8000u >> arg[1].imm);
-#else
-tcg_gen_andi_i32(tmp, arg[0].in, 0x0001u << arg[1].imm);
-#endif
+if (TARGET_BIG_ENDIAN) {
+tcg_gen_andi_i32(tmp, arg[0].in, 0x8000u >> arg[1].imm);
+} else {
+tcg_gen_andi_i32(tmp, arg[0].in, 0x0001u << arg[1].imm);
+}
 gen_brcondi(dc, par[0], tmp, 0, arg[2].imm);
 }
 
-- 
2.47.1