Re: [PATCH 7/8] hw/microblaze: Evaluate TARGET_BIG_ENDIAN at compile time

[Richard Henderson]

On 4/17/25 06:10, Philippe Mathieu-Daudé wrote:

Rather than evaluating TARGET_BIG_ENDIAN at preprocessing
time via #ifdef'ry, do it in C at compile time

Signed-off-by: Philippe Mathieu-Daudé
---
  hw/microblaze/petalogix_ml605_mmu.c | 12 ++--
  hw/microblaze/xlnx-zynqmp-pmu.c | 12 ++--
  2 files changed, 12 insertions(+), 12 deletions(-)


Reviewed-by: Richard Henderson 

r~

[PATCH 7/8] hw/microblaze: Evaluate TARGET_BIG_ENDIAN at compile time

[Philippe Mathieu-Daudé]

Rather than evaluating TARGET_BIG_ENDIAN at preprocessing
time via #ifdef'ry, do it in C at compile time

Signed-off-by: Philippe Mathieu-Daudé 
---
 hw/microblaze/petalogix_ml605_mmu.c | 12 ++--
 hw/microblaze/xlnx-zynqmp-pmu.c | 12 ++--
 2 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/hw/microblaze/petalogix_ml605_mmu.c 
b/hw/microblaze/petalogix_ml605_mmu.c
index c887c7a99ed..bea6b689fd1 100644
--- a/hw/microblaze/petalogix_ml605_mmu.c
+++ b/hw/microblaze/petalogix_ml605_mmu.c
@@ -218,12 +218,12 @@ petalogix_ml605_init(MachineState *machine)
 
 static void petalogix_ml605_machine_init(MachineClass *mc)
 {
-#if TARGET_BIG_ENDIAN
-mc->desc = "PetaLogix linux refdesign for xilinx ml605 (big endian)";
-mc->deprecation_reason = "big endian support is not tested";
-#else
-mc->desc = "PetaLogix linux refdesign for xilinx ml605 (little endian)";
-#endif
+if (TARGET_BIG_ENDIAN) {
+mc->desc = "PetaLogix linux refdesign for xilinx ml605 (big endian)";
+mc->deprecation_reason = "big endian support is not tested";
+} else {
+mc->desc = "PetaLogix linux refdesign for xilinx ml605 (little 
endian)";
+}
 mc->init = petalogix_ml605_init;
 }
 
diff --git a/hw/microblaze/xlnx-zynqmp-pmu.c b/hw/microblaze/xlnx-zynqmp-pmu.c
index 0922c652957..2efacc53feb 100644
--- a/hw/microblaze/xlnx-zynqmp-pmu.c
+++ b/hw/microblaze/xlnx-zynqmp-pmu.c
@@ -181,12 +181,12 @@ static void xlnx_zynqmp_pmu_init(MachineState *machine)
 
 static void xlnx_zynqmp_pmu_machine_init(MachineClass *mc)
 {
-#if TARGET_BIG_ENDIAN
-mc->desc = "Xilinx ZynqMP PMU machine (big endian)";
-mc->deprecation_reason = "big endian support is not tested";
-#else
-mc->desc = "Xilinx ZynqMP PMU machine (little endian)";
-#endif
+if (TARGET_BIG_ENDIAN) {
+mc->desc = "Xilinx ZynqMP PMU machine (big endian)";
+mc->deprecation_reason = "big endian support is not tested";
+} else {
+mc->desc = "Xilinx ZynqMP PMU machine (little endian)";
+}
 mc->init = xlnx_zynqmp_pmu_init;
 }
 
-- 
2.47.1