Re: [PATCH for-9.1 14/19] target/i386: move BSWAP to new decoder

2024-04-11 Thread Richard Henderson 

On 4/9/24 09:43, Paolo Bonzini wrote:

Signed-off-by: Paolo Bonzini 
---
  target/i386/tcg/translate.c  |  4 +++-
  target/i386/tcg/decode-new.c.inc |  9 +
  target/i386/tcg/emit.c.inc   | 11 +++
  3 files changed, 23 insertions(+), 1 deletion(-)

diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c
index f3c437aee88..a1e6e8ec7d9 100644
--- a/target/i386/tcg/translate.c
+++ b/target/i386/tcg/translate.c
@@ -3209,7 +3209,9 @@ static bool disas_insn(DisasContext *s, CPUState *cpu)
  #ifndef CONFIG_USER_ONLY
  use_new &= b <= limit;
  #endif
-if (use_new && (b >= 0x138 && b <= 0x19f)) {
+if (use_new &&
+   ((b >= 0x138 && b <= 0x19f) ||
+ (b >= 0x1c8 && b <= 0x1cf))) {


Tab.

Otherwise,
Reviewed-by: Richard Henderson 


r~

[PATCH for-9.1 14/19] target/i386: move BSWAP to new decoder

2024-04-09 Thread Paolo Bonzini 
Signed-off-by: Paolo Bonzini 
---
 target/i386/tcg/translate.c  |  4 +++-
 target/i386/tcg/decode-new.c.inc |  9 +
 target/i386/tcg/emit.c.inc   | 11 +++
 3 files changed, 23 insertions(+), 1 deletion(-)

diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c
index f3c437aee88..a1e6e8ec7d9 100644
--- a/target/i386/tcg/translate.c
+++ b/target/i386/tcg/translate.c
@@ -3209,7 +3209,9 @@ static bool disas_insn(DisasContext *s, CPUState *cpu)
 #ifndef CONFIG_USER_ONLY
 use_new &= b <= limit;
 #endif
-if (use_new && (b >= 0x138 && b <= 0x19f)) {
+if (use_new &&
+   ((b >= 0x138 && b <= 0x19f) ||
+ (b >= 0x1c8 && b <= 0x1cf))) {
 disas_insn_new(s, cpu, b);
 return true;
 }
diff --git a/target/i386/tcg/decode-new.c.inc b/target/i386/tcg/decode-new.c.inc
index 36eb53515af..2ee949b50e2 100644
--- a/target/i386/tcg/decode-new.c.inc
+++ b/target/i386/tcg/decode-new.c.inc
@@ -1118,6 +1118,15 @@ static const X86OpEntry opcodes_0F[256] = {
 [0xc5] = X86_OP_ENTRY3(PEXTRW, G,d, U,dq,I,b,   vex5 mmx p_00_66),
 [0xc6] = X86_OP_ENTRY4(VSHUF,  V,x, H,x, W,x,   vex4 p_00_66),
 
+[0xc8] = X86_OP_ENTRY1(BSWAP, LoBits,y),
+[0xc9] = X86_OP_ENTRY1(BSWAP, LoBits,y),
+[0xca] = X86_OP_ENTRY1(BSWAP, LoBits,y),
+[0xcb] = X86_OP_ENTRY1(BSWAP, LoBits,y),
+[0xcc] = X86_OP_ENTRY1(BSWAP, LoBits,y),
+[0xcd] = X86_OP_ENTRY1(BSWAP, LoBits,y),
+[0xce] = X86_OP_ENTRY1(BSWAP, LoBits,y),
+[0xcf] = X86_OP_ENTRY1(BSWAP, LoBits,y),
+
 [0xd0] = X86_OP_ENTRY3(VADDSUB,   V,x, H,x, W,x,vex2 cpuid(SSE3) 
p_66_f2),
 [0xd1] = X86_OP_ENTRY3(PSRLW_r,   V,x, H,x, W,x,vex4 mmx avx2_256 
p_00_66),
 [0xd2] = X86_OP_ENTRY3(PSRLD_r,   V,x, H,x, W,x,vex4 mmx avx2_256 
p_00_66),
diff --git a/target/i386/tcg/emit.c.inc b/target/i386/tcg/emit.c.inc
index dc5142be51f..1dc246f8c1e 100644
--- a/target/i386/tcg/emit.c.inc
+++ b/target/i386/tcg/emit.c.inc
@@ -1299,6 +1299,17 @@ static void gen_BOUND(DisasContext *s, CPUX86State *env, 
X86DecodedInsn *decode)
 }
 }
 
+static void gen_BSWAP(DisasContext *s, CPUX86State *env, X86DecodedInsn 
*decode)
+{
+#ifdef TARGET_X86_64
+if (s->dflag == MO_64) {
+tcg_gen_bswap64_i64(s->T0, s->T0);
+return;
+}
+#endif
+tcg_gen_bswap32_tl(s->T0, s->T0, TCG_BSWAP_OZ);
+}
+
 static void gen_BZHI(DisasContext *s, CPUX86State *env, X86DecodedInsn *decode)
 {
 MemOp ot = decode->op[0].ot;
-- 
2.44.0