Re: [PATCH v2 04/13] gdbstub: Add trace events for around XML parsing / generation

2026-03-10 Thread Pierrick Bouvier

On 3/10/26 8:53 AM, Philippe Mathieu-Daudé wrote:

Add trace events to help follow how the various files in
gdb-xml/ are parsed or generated at runtime.

Signed-off-by: Philippe Mathieu-Daudé 
---
  gdbstub/gdbstub.c| 10 ++
  gdbstub/trace-events |  5 +
  2 files changed, 15 insertions(+)



Reviewed-by: Pierrick Bouvier 



[PATCH v2 04/13] gdbstub: Add trace events for around XML parsing / generation

2026-03-10 Thread Philippe Mathieu-Daudé
Add trace events to help follow how the various files in
gdb-xml/ are parsed or generated at runtime.

Signed-off-by: Philippe Mathieu-Daudé 
---
 gdbstub/gdbstub.c| 10 ++
 gdbstub/trace-events |  5 +
 2 files changed, 15 insertions(+)

diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c
index 139301b485d..9703688eecc 100644
--- a/gdbstub/gdbstub.c
+++ b/gdbstub/gdbstub.c
@@ -478,6 +478,10 @@ void gdb_feature_builder_end(const GDBFeatureBuilder 
*builder)
 
 builder->feature->num_regs = builder->regs->len;
 builder->feature->regs = (void *)g_ptr_array_free(builder->regs, FALSE);
+trace_gdbxml_feature_builder_header(builder->feature->name,
+builder->feature->xmlname,
+builder->feature->num_regs);
+trace_gdbxml_feature_builder_content(builder->feature->xml);
 }
 
 const GDBFeature *gdb_find_static_feature(const char *xmlname)
@@ -563,6 +567,8 @@ static void gdb_register_feature(CPUState *cpu, int 
base_reg,
 .feature = feature
 };
 
+trace_gdbxml_register_feature(feature->name, feature->xmlname,
+  base_reg, feature->num_regs);
 g_array_append_val(cpu->gdb_regs, s);
 }
 
@@ -599,6 +605,10 @@ void gdb_init_cpu(CPUState *cpu)
 assert(cc->gdb_num_core_regs);
 cpu->gdb_num_regs = cpu->gdb_num_g_regs = cc->gdb_num_core_regs;
 }
+
+trace_gdbxml_init_cpu(object_get_typename(OBJECT(cpu)), cpu->cpu_index,
+  cpu->gdb_num_regs, cpu->gdb_num_g_regs,
+  cc->gdb_num_core_regs);
 }
 
 void gdb_register_coprocessor(CPUState *cpu,
diff --git a/gdbstub/trace-events b/gdbstub/trace-events
index 4fd126a38c1..44ef3339934 100644
--- a/gdbstub/trace-events
+++ b/gdbstub/trace-events
@@ -28,5 +28,10 @@ gdbstub_err_checksum_invalid(uint8_t ch) "got invalid 
command checksum digit: 0x
 gdbstub_err_checksum_incorrect(uint8_t expected, uint8_t got) "got command 
packet with incorrect checksum, expected=0x%02x, received=0x%02x"
 gdbstub_err_unexpected_runpkt(uint8_t ch) "unexpected packet (0x%02x) while 
target running"
 
+gdbxml_init_cpu(const char *typename, unsigned id, unsigned gdb_num_regs, 
unsigned gdb_num_g_regs, unsigned gdb_num_core_regs) "%s:%d regs:%u g_regs:%u 
core_regs:%u"
+gdbxml_register_feature(const char *featname, const char *xmlname, unsigned 
base_reg, unsigned num_regs) "%s (%s) @%u +%u"
+gdbxml_feature_builder_header(const char *name, const char *xmlname, int 
num_regs) "%s (%s) regs:%d"
+gdbxml_feature_builder_content(const char *xml) "%s"
+
 # system.c
 gdbstub_hit_watchpoint(const char *type, int cpu_gdb_index, uint64_t vaddr) 
"Watchpoint hit, type=\"%s\" cpu=%d, vaddr=0x%" PRIx64 ""
-- 
2.53.0