Re: [PATCH v2 2/2] system/vl: Update description for input grab key

[Michael Tokarev]

22.02.2024 15:50, Tianlan Zhou wrote:

Cc qemu-stable, as this will fix the `qemu-system-xxx -h` help message.


Yes, I already picked up both of them.

/mjt

Re: [PATCH v2 2/2] system/vl: Update description for input grab key

[Tianlan Zhou]

Cc qemu-stable, as this will fix the `qemu-system-xxx -h` help message.


On 2024/2/22 3:52, Tianlan Zhou wrote:
> Input grab key should be Ctrl-Alt-g, not just Ctrl-Alt.
> 
> Signed-off-by: Tianlan Zhou 
> ---
>  system/vl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/system/vl.c b/system/vl.c
> index a82555ae15..b8469d9965 100644
> --- a/system/vl.c
> +++ b/system/vl.c
> @@ -891,7 +891,7 @@ static void help(int exitcode)
>  printf("\nDuring emulation, the following keys are useful:\n"
> "ctrl-alt-f  toggle full screen\n"
> "ctrl-alt-n  switch to virtual console 'n'\n"
> -   "ctrl-alttoggle mouse and keyboard grab\n"
> +   "ctrl-alt-g  toggle mouse and keyboard grab\n"
> "\n"
> "When using -nographic, press 'ctrl-a h' to get some help.\n"
> "\n"
> -- 
> 2.38.1.windows.1

Re: [PATCH v2 2/2] system/vl: Update description for input grab key

[Thomas Huth]

On 21/02/2024 20.52, Tianlan Zhou wrote:

Input grab key should be Ctrl-Alt-g, not just Ctrl-Alt.

Signed-off-by: Tianlan Zhou 
---
  system/vl.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/system/vl.c b/system/vl.c
index a82555ae15..b8469d9965 100644
--- a/system/vl.c
+++ b/system/vl.c
@@ -891,7 +891,7 @@ static void help(int exitcode)
  printf("\nDuring emulation, the following keys are useful:\n"
 "ctrl-alt-f  toggle full screen\n"
 "ctrl-alt-n  switch to virtual console 'n'\n"
-   "ctrl-alttoggle mouse and keyboard grab\n"
+   "ctrl-alt-g  toggle mouse and keyboard grab\n"
 "\n"
 "When using -nographic, press 'ctrl-a h' to get some help.\n"
 "\n"


Fixes: f8d2c9369b ("sdl: use ctrl-alt-g as grab hotkey")

Reviewed-by: Thomas Huth 

[PATCH v2 2/2] system/vl: Update description for input grab key

[Tianlan Zhou]

Input grab key should be Ctrl-Alt-g, not just Ctrl-Alt.

Signed-off-by: Tianlan Zhou 
---
 system/vl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/system/vl.c b/system/vl.c
index a82555ae15..b8469d9965 100644
--- a/system/vl.c
+++ b/system/vl.c
@@ -891,7 +891,7 @@ static void help(int exitcode)
 printf("\nDuring emulation, the following keys are useful:\n"
"ctrl-alt-f  toggle full screen\n"
"ctrl-alt-n  switch to virtual console 'n'\n"
-   "ctrl-alttoggle mouse and keyboard grab\n"
+   "ctrl-alt-g  toggle mouse and keyboard grab\n"
"\n"
"When using -nographic, press 'ctrl-a h' to get some help.\n"
"\n"
-- 
2.38.1.windows.1