Re: [PATCH v3 10/19] target/arm: Restrict ARMv4 cpus to TCG accel

2020-04-23 Thread Philippe Mathieu-Daudé
On 3/16/20 5:06 PM, Philippe Mathieu-Daudé wrote: KVM requires a cpu based on (at least) the ARMv7 architecture. Only enable the following ARMv4 CPUs when TCG is available: - StrongARM (SA1100/1110) - OMAP1510 (TI925T) I missed to explain, the point of this Kconfig granularity is on a

Re: [PATCH v3 10/19] target/arm: Restrict ARMv4 cpus to TCG accel

2020-03-16 Thread Richard Henderson
On 3/16/20 12:50 PM, Richard Henderson wrote: > I much prefer ARRAY_SIZE() to sentinels. > I know the existing code make much use of them, > but we don't need to replicate that here. ... but otherwise, Reviewed-by: Richard Henderson r~

Re: [PATCH v3 10/19] target/arm: Restrict ARMv4 cpus to TCG accel

2020-03-16 Thread Richard Henderson
On 3/16/20 9:06 AM, Philippe Mathieu-Daudé wrote: > +static const ARMCPUInfo arm_v4_cpus[] = { > +{ .name = "ti925t", .initfn = ti925t_initfn }, > +{ .name = "sa1100", .initfn = sa1100_initfn }, > +{ .name = "sa1110", .initfn = sa1110_initfn }, > +{ .name = NULL } >

[PATCH v3 10/19] target/arm: Restrict ARMv4 cpus to TCG accel

2020-03-16 Thread Philippe Mathieu-Daudé
KVM requires a cpu based on (at least) the ARMv7 architecture. Only enable the following ARMv4 CPUs when TCG is available: - StrongARM (SA1100/1110) - OMAP1510 (TI925T) Signed-off-by: Philippe Mathieu-Daudé --- default-configs/arm-softmmu.mak | 2 - target/arm/cpu.c| 33