Re: [SPAM] [PATCH v3 11/18] hw/arm/aspeed: Attach ADC device to AST1700 model

2025-12-19 Thread Cédric Le Goater 

On 12/8/25 08:44, Kane Chen wrote:

From: Kane-Chen-AS 

Connect the ADC device to AST1700 model.

Signed-off-by: Kane-Chen-AS 
---
  include/hw/arm/aspeed_ast1700.h |  2 ++
  hw/arm/aspeed_ast1700.c | 14 ++
  hw/arm/aspeed_ast27x0.c |  5 +
  3 files changed, 21 insertions(+)




Reviewed-by: Cédric Le Goater 

Thanks,

C.




diff --git a/include/hw/arm/aspeed_ast1700.h b/include/hw/arm/aspeed_ast1700.h
index 5b120dd11a..0c1216c4ba 100644
--- a/include/hw/arm/aspeed_ast1700.h
+++ b/include/hw/arm/aspeed_ast1700.h
@@ -9,6 +9,7 @@
  #define ASPEED_AST1700_H
  
  #include "hw/sysbus.h"

+#include "hw/adc/aspeed_adc.h"
  #include "hw/misc/aspeed_ltpi.h"
  #include "hw/ssi/aspeed_smc.h"
  #include "hw/char/serial-mm.h"
@@ -27,6 +28,7 @@ struct AspeedAST1700SoCState {
  SerialMM uart;
  MemoryRegion sram;
  AspeedSMCState spi;
+AspeedADCState adc;
  };
  
  #endif /* ASPEED_AST1700_H */

diff --git a/hw/arm/aspeed_ast1700.c b/hw/arm/aspeed_ast1700.c
index 62808f7c60..967264aec9 100644
--- a/hw/arm/aspeed_ast1700.c
+++ b/hw/arm/aspeed_ast1700.c
@@ -19,6 +19,7 @@
  enum {
  ASPEED_AST1700_DEV_SPI0,
  ASPEED_AST1700_DEV_SRAM,
+ASPEED_AST1700_DEV_ADC,
  ASPEED_AST1700_DEV_UART12,
  ASPEED_AST1700_DEV_LTPI_CTRL,
  ASPEED_AST1700_DEV_SPI0_MEM,
@@ -27,6 +28,7 @@ enum {
  static const hwaddr aspeed_ast1700_io_memmap[] = {
  [ASPEED_AST1700_DEV_SPI0]  =  0x0003,
  [ASPEED_AST1700_DEV_SRAM]  =  0x00BC,
+[ASPEED_AST1700_DEV_ADC]   =  0x00C0,
  [ASPEED_AST1700_DEV_UART12]=  0x00C33B00,
  [ASPEED_AST1700_DEV_LTPI_CTRL] =  0x00C34000,
  [ASPEED_AST1700_DEV_SPI0_MEM]  =  0x0400,
@@ -76,6 +78,14 @@ static void aspeed_ast1700_realize(DeviceState *dev, Error 
**errp)
  aspeed_ast1700_io_memmap[ASPEED_AST1700_DEV_SPI0_MEM],
  sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->spi), 1));
  
+/* ADC */

+if (!sysbus_realize(SYS_BUS_DEVICE(&s->adc), errp)) {
+return;
+}
+memory_region_add_subregion(&s->iomem,
+aspeed_ast1700_io_memmap[ASPEED_AST1700_DEV_ADC],
+sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->adc), 0));
+
  /* LTPI controller */
  if (!sysbus_realize(SYS_BUS_DEVICE(&s->ltpi), errp)) {
  return;
@@ -97,6 +107,10 @@ static void aspeed_ast1700_instance_init(Object *obj)
  object_initialize_child(obj, "ioexp-spi[*]", &s->spi,
  "aspeed.spi0-ast2700");
  
+/* ADC */

+object_initialize_child(obj, "ioexp-adc[*]", &s->adc,
+"aspeed.adc-ast2700");
+
  /* LTPI controller */
  object_initialize_child(obj, "ltpi-ctrl",
  &s->ltpi, TYPE_ASPEED_LTPI);
diff --git a/hw/arm/aspeed_ast27x0.c b/hw/arm/aspeed_ast27x0.c
index 66c877a6a4..726b31031b 100644
--- a/hw/arm/aspeed_ast27x0.c
+++ b/hw/arm/aspeed_ast27x0.c
@@ -1117,6 +1117,11 @@ static void aspeed_soc_ast2700_realize(DeviceState *dev, 
Error **errp)
  sysbus_connect_irq(SYS_BUS_DEVICE(&a->intcioexp[i]), j,
 irq);
  }
+
+/* ADC */
+sysbus_connect_irq(SYS_BUS_DEVICE(&s->ioexp[i].adc), 0,
+   aspeed_soc_ast2700_get_irq(s, ASPEED_DEV_ADC));
+
  }
  
  aspeed_mmio_map_unimplemented(s->memory, SYS_BUS_DEVICE(&s->dpmcu),

[PATCH v3 11/18] hw/arm/aspeed: Attach ADC device to AST1700 model

2025-12-07 Thread Kane Chen via 
From: Kane-Chen-AS 

Connect the ADC device to AST1700 model.

Signed-off-by: Kane-Chen-AS 
---
 include/hw/arm/aspeed_ast1700.h |  2 ++
 hw/arm/aspeed_ast1700.c | 14 ++
 hw/arm/aspeed_ast27x0.c |  5 +
 3 files changed, 21 insertions(+)

diff --git a/include/hw/arm/aspeed_ast1700.h b/include/hw/arm/aspeed_ast1700.h
index 5b120dd11a..0c1216c4ba 100644
--- a/include/hw/arm/aspeed_ast1700.h
+++ b/include/hw/arm/aspeed_ast1700.h
@@ -9,6 +9,7 @@
 #define ASPEED_AST1700_H
 
 #include "hw/sysbus.h"
+#include "hw/adc/aspeed_adc.h"
 #include "hw/misc/aspeed_ltpi.h"
 #include "hw/ssi/aspeed_smc.h"
 #include "hw/char/serial-mm.h"
@@ -27,6 +28,7 @@ struct AspeedAST1700SoCState {
 SerialMM uart;
 MemoryRegion sram;
 AspeedSMCState spi;
+AspeedADCState adc;
 };
 
 #endif /* ASPEED_AST1700_H */
diff --git a/hw/arm/aspeed_ast1700.c b/hw/arm/aspeed_ast1700.c
index 62808f7c60..967264aec9 100644
--- a/hw/arm/aspeed_ast1700.c
+++ b/hw/arm/aspeed_ast1700.c
@@ -19,6 +19,7 @@
 enum {
 ASPEED_AST1700_DEV_SPI0,
 ASPEED_AST1700_DEV_SRAM,
+ASPEED_AST1700_DEV_ADC,
 ASPEED_AST1700_DEV_UART12,
 ASPEED_AST1700_DEV_LTPI_CTRL,
 ASPEED_AST1700_DEV_SPI0_MEM,
@@ -27,6 +28,7 @@ enum {
 static const hwaddr aspeed_ast1700_io_memmap[] = {
 [ASPEED_AST1700_DEV_SPI0]  =  0x0003,
 [ASPEED_AST1700_DEV_SRAM]  =  0x00BC,
+[ASPEED_AST1700_DEV_ADC]   =  0x00C0,
 [ASPEED_AST1700_DEV_UART12]=  0x00C33B00,
 [ASPEED_AST1700_DEV_LTPI_CTRL] =  0x00C34000,
 [ASPEED_AST1700_DEV_SPI0_MEM]  =  0x0400,
@@ -76,6 +78,14 @@ static void aspeed_ast1700_realize(DeviceState *dev, Error 
**errp)
 aspeed_ast1700_io_memmap[ASPEED_AST1700_DEV_SPI0_MEM],
 sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->spi), 1));
 
+/* ADC */
+if (!sysbus_realize(SYS_BUS_DEVICE(&s->adc), errp)) {
+return;
+}
+memory_region_add_subregion(&s->iomem,
+aspeed_ast1700_io_memmap[ASPEED_AST1700_DEV_ADC],
+sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->adc), 0));
+
 /* LTPI controller */
 if (!sysbus_realize(SYS_BUS_DEVICE(&s->ltpi), errp)) {
 return;
@@ -97,6 +107,10 @@ static void aspeed_ast1700_instance_init(Object *obj)
 object_initialize_child(obj, "ioexp-spi[*]", &s->spi,
 "aspeed.spi0-ast2700");
 
+/* ADC */
+object_initialize_child(obj, "ioexp-adc[*]", &s->adc,
+"aspeed.adc-ast2700");
+
 /* LTPI controller */
 object_initialize_child(obj, "ltpi-ctrl",
 &s->ltpi, TYPE_ASPEED_LTPI);
diff --git a/hw/arm/aspeed_ast27x0.c b/hw/arm/aspeed_ast27x0.c
index 66c877a6a4..726b31031b 100644
--- a/hw/arm/aspeed_ast27x0.c
+++ b/hw/arm/aspeed_ast27x0.c
@@ -1117,6 +1117,11 @@ static void aspeed_soc_ast2700_realize(DeviceState *dev, 
Error **errp)
 sysbus_connect_irq(SYS_BUS_DEVICE(&a->intcioexp[i]), j,
irq);
 }
+
+/* ADC */
+sysbus_connect_irq(SYS_BUS_DEVICE(&s->ioexp[i].adc), 0,
+   aspeed_soc_ast2700_get_irq(s, ASPEED_DEV_ADC));
+
 }
 
 aspeed_mmio_map_unimplemented(s->memory, SYS_BUS_DEVICE(&s->dpmcu),
-- 
2.43.0