Re: [PATCH v3 13/19] target/arm: Restrict ARMv7 R-profile cpus to TCG accel

2020-03-16 Thread Richard Henderson
On 3/16/20 9:06 AM, Philippe Mathieu-Daudé wrote:
> +static void arm_v7r_cpu_register_types(void)
> +{
> +const ARMCPUInfo *info = arm_v7r_cpus;
> +
> +while (info->name) {
> +arm_cpu_register(info);
> +info++;
> +}
> +}

Likewise wrt ARRAY_SIZE, otherwise,
Reviewed-by: Richard Henderson 


r~



[PATCH v3 13/19] target/arm: Restrict ARMv7 R-profile cpus to TCG accel

2020-03-16 Thread Philippe Mathieu-Daudé
A KVM-only build won't be able to run R-profile cpus.

Only enable the following ARMv7 R-Profile CPUs when TCG is available:

  - Cortex-R5
  - Cortex-R5F

Signed-off-by: Philippe Mathieu-Daudé 
---
 default-configs/aarch64-softmmu.mak |  1 -
 target/arm/cpu.c| 51 --
 target/arm/cpu_v7r.c| 83 +
 hw/arm/Kconfig  |  1 +
 target/arm/Kconfig  |  4 ++
 target/arm/Makefile.objs|  1 +
 6 files changed, 89 insertions(+), 52 deletions(-)
 create mode 100644 target/arm/cpu_v7r.c

diff --git a/default-configs/aarch64-softmmu.mak 
b/default-configs/aarch64-softmmu.mak
index 958b1e08e4..a4202f5681 100644
--- a/default-configs/aarch64-softmmu.mak
+++ b/default-configs/aarch64-softmmu.mak
@@ -3,6 +3,5 @@
 # We support all the 32 bit boards so need all their config
 include arm-softmmu.mak
 
-CONFIG_XLNX_ZYNQMP_ARM=y
 CONFIG_XLNX_VERSAL=y
 CONFIG_SBSA_REF=y
diff --git a/target/arm/cpu.c b/target/arm/cpu.c
index 34908828a0..84be8792f6 100644
--- a/target/arm/cpu.c
+++ b/target/arm/cpu.c
@@ -1975,55 +1975,6 @@ static void arm_v7m_class_init(ObjectClass *oc, void 
*data)
 cc->cpu_exec_interrupt = arm_v7m_cpu_exec_interrupt;
 }
 
-static const ARMCPRegInfo cortexr5_cp_reginfo[] = {
-/* Dummy the TCM region regs for the moment */
-{ .name = "ATCM", .cp = 15, .opc1 = 0, .crn = 9, .crm = 1, .opc2 = 0,
-  .access = PL1_RW, .type = ARM_CP_CONST },
-{ .name = "BTCM", .cp = 15, .opc1 = 0, .crn = 9, .crm = 1, .opc2 = 1,
-  .access = PL1_RW, .type = ARM_CP_CONST },
-{ .name = "DCACHE_INVAL", .cp = 15, .opc1 = 0, .crn = 15, .crm = 5,
-  .opc2 = 0, .access = PL1_W, .type = ARM_CP_NOP },
-REGINFO_SENTINEL
-};
-
-static void cortex_r5_initfn(Object *obj)
-{
-ARMCPU *cpu = ARM_CPU(obj);
-
-set_feature(>env, ARM_FEATURE_V7);
-set_feature(>env, ARM_FEATURE_V7MP);
-set_feature(>env, ARM_FEATURE_PMSA);
-set_feature(>env, ARM_FEATURE_PMU);
-cpu->midr = 0x411fc153; /* r1p3 */
-cpu->id_pfr0 = 0x0131;
-cpu->id_pfr1 = 0x001;
-cpu->isar.id_dfr0 = 0x010400;
-cpu->id_afr0 = 0x0;
-cpu->isar.id_mmfr0 = 0x0210030;
-cpu->isar.id_mmfr1 = 0x;
-cpu->isar.id_mmfr2 = 0x0120;
-cpu->isar.id_mmfr3 = 0x0211;
-cpu->isar.id_isar0 = 0x0210;
-cpu->isar.id_isar1 = 0x13112111;
-cpu->isar.id_isar2 = 0x21232141;
-cpu->isar.id_isar3 = 0x01112131;
-cpu->isar.id_isar4 = 0x0010142;
-cpu->isar.id_isar5 = 0x0;
-cpu->isar.id_isar6 = 0x0;
-cpu->mp_is_up = true;
-cpu->pmsav7_dregion = 16;
-define_arm_cp_regs(cpu, cortexr5_cp_reginfo);
-}
-
-static void cortex_r5f_initfn(Object *obj)
-{
-ARMCPU *cpu = ARM_CPU(obj);
-
-cortex_r5_initfn(obj);
-cpu->isar.mvfr0 = 0x10110221;
-cpu->isar.mvfr1 = 0x0011;
-}
-
 static const ARMCPRegInfo cortexa8_cp_reginfo[] = {
 { .name = "L2LOCKDOWN", .cp = 15, .crn = 9, .crm = 0, .opc1 = 1, .opc2 = 0,
   .access = PL1_RW, .type = ARM_CP_CONST, .resetvalue = 0 },
@@ -2333,8 +2284,6 @@ static const ARMCPUInfo arm_cpus[] = {
  .class_init = arm_v7m_class_init },
 { .name = "cortex-m33",  .initfn = cortex_m33_initfn,
  .class_init = arm_v7m_class_init },
-{ .name = "cortex-r5",   .initfn = cortex_r5_initfn },
-{ .name = "cortex-r5f",  .initfn = cortex_r5f_initfn },
 { .name = "cortex-a7",   .initfn = cortex_a7_initfn },
 { .name = "cortex-a8",   .initfn = cortex_a8_initfn },
 { .name = "cortex-a9",   .initfn = cortex_a9_initfn },
diff --git a/target/arm/cpu_v7r.c b/target/arm/cpu_v7r.c
new file mode 100644
index 00..9576844b5c
--- /dev/null
+++ b/target/arm/cpu_v7r.c
@@ -0,0 +1,83 @@
+/*
+ * ARM generic helpers.
+ *
+ * This code is licensed under the GNU GPL v2 or later.
+ *
+ * SPDX-License-Identifier: GPL-2.0-or-later
+ */
+
+#include "qemu/osdep.h"
+#include "cpu.h"
+#include "internals.h"
+
+/* CPU models. These are not needed for the AArch64 linux-user build. */
+#if !defined(CONFIG_USER_ONLY) || !defined(TARGET_AARCH64)
+
+static const ARMCPRegInfo cortexr5_cp_reginfo[] = {
+/* Dummy the TCM region regs for the moment */
+{ .name = "ATCM", .cp = 15, .opc1 = 0, .crn = 9, .crm = 1, .opc2 = 0,
+  .access = PL1_RW, .type = ARM_CP_CONST },
+{ .name = "BTCM", .cp = 15, .opc1 = 0, .crn = 9, .crm = 1, .opc2 = 1,
+  .access = PL1_RW, .type = ARM_CP_CONST },
+{ .name = "DCACHE_INVAL", .cp = 15, .opc1 = 0, .crn = 15, .crm = 5,
+  .opc2 = 0, .access = PL1_W, .type = ARM_CP_NOP },
+REGINFO_SENTINEL
+};
+
+static void cortex_r5_initfn(Object *obj)
+{
+ARMCPU *cpu = ARM_CPU(obj);
+
+set_feature(>env, ARM_FEATURE_V7);
+set_feature(>env, ARM_FEATURE_V7MP);
+set_feature(>env, ARM_FEATURE_PMSA);
+set_feature(>env, ARM_FEATURE_PMU);
+cpu->midr = 0x411fc153; /* r1p3 */
+cpu->id_pfr0 = 0x0131;
+cpu->id_pfr1 = 0x001;
+