Re: [PATCH v3 20/26] x86: Fix x86_cpu_new() error handling

2020-07-02 Thread Paolo Bonzini
On 02/07/20 06:51, Markus Armbruster wrote: > Igor, Paolo, you showed me the error in v2. Could you have a look at > this revision? > > Markus Armbruster writes: > >> The Error ** argument must be NULL, _abort, _fatal, or a >> pointer to a variable containing NULL. Passing an argument of the

Re: [PATCH v3 20/26] x86: Fix x86_cpu_new() error handling

2020-07-01 Thread Markus Armbruster
Igor, Paolo, you showed me the error in v2. Could you have a look at this revision? Markus Armbruster writes: > The Error ** argument must be NULL, _abort, _fatal, or a > pointer to a variable containing NULL. Passing an argument of the > latter kind twice without clearing it in between is

[PATCH v3 20/26] x86: Fix x86_cpu_new() error handling

2020-06-30 Thread Markus Armbruster
The Error ** argument must be NULL, _abort, _fatal, or a pointer to a variable containing NULL. Passing an argument of the latter kind twice without clearing it in between is wrong: if the first call sets an error, it no longer points to NULL for the second call. x86_cpu_new() is wrong that way: