Re: [PATCH v5 35/36] qtest/bios-tables-test: Generate reference blob for DSDT.hpoffacpiindex

2025-07-07 Thread Eric Auger
Hi Jonathan,

On 7/3/25 5:02 PM, Jonathan Cameron wrote:
> On Thu,  3 Jul 2025 14:35:35 +0200
> Eric Auger  wrote:
>
>> The disassembled DSDT table is given below
> I'd suggest maybe a spot of cropping to bring this down to a reasonable 
> length.
> See inline.
Yup. I can do that.
>
> Otherwise LGTM
>
> Reviewed-by: Jonathan Cameron 
many thanks!

Eric
>
>>  * Original Table Header:
>>  * Signature"DSDT"
>>  * Length   0x14E3 (5347)
>>  * Revision 0x02
>>  * Checksum 0x92
>>  * OEM ID   "BOCHS "
>>  * OEM Table ID "BXPC"
>>  * OEM Revision 0x0001 (1)
>>  * Compiler ID  "BXPC"
>>  * Compiler Version 0x0001 (1)
>>  */
>> DefinitionBlock ("", "DSDT", 2, "BOCHS ", "BXPC", 0x0001)
>> {
>> Scope (\_SB)
>> {
>> Device (C000)
>> {
>> Name (_HID, "ACPI0007" /* Processor Device */)  // _HID: 
>> Hardware ID
>> Name (_UID, Zero)  // _UID: Unique ID
>> }
>>
>> Device (COM0)
>> {
>> Name (_HID, "ARMH0011")  // _HID: Hardware ID
>> Name (_UID, Zero)  // _UID: Unique ID
>> Name (_CRS, ResourceTemplate ()  // _CRS: Current Resource 
>> Settings
>> {
>> Memory32Fixed (ReadWrite,
>> 0x0900, // Address Base
>> 0x1000, // Address Length
>> )
>> Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive, 
>> ,, )
>> {
>> 0x0021,
>> }
>> })
>> }
>>
>> Device (FWCF)
>> {
>> Name (_HID, "QEMU0002")  // _HID: Hardware ID
>> Name (_STA, 0x0B)  // _STA: Status
>> Name (_CCA, One)  // _CCA: Cache Coherency Attribute
>> Name (_CRS, ResourceTemplate ()  // _CRS: Current Resource 
>> Settings
>> {
>> Memory32Fixed (ReadWrite,
>> 0x0902, // Address Base
>> 0x0018, // Address Length
>> )
>> })
>> }
>>
>> Device (VR00)
>> {
>> Name (_HID, "LNRO0005")  // _HID: Hardware ID
>> Name (_UID, Zero)  // _UID: Unique ID
>> Name (_CCA, One)  // _CCA: Cache Coherency Attribute
>> Name (_CRS, ResourceTemplate ()  // _CRS: Current Resource 
>> Settings
>> {
>> Memory32Fixed (ReadWrite,
>> 0x0A00, // Address Base
>> 0x0200, // Address Length
>> )
>> Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive, 
>> ,, )
>> {
>> 0x0030,
>> }
>> })
>> }
> If you want to keep these, maybe a single representative LNRO0005 only.
>
>> Device (PCI0)
>> {
>> Name (_HID, "PNP0A08" /* PCI Express Bus */)  // _HID: Hardware 
>> ID
>> Name (_CID, "PNP0A03" /* PCI Bus */)  // _CID: Compatible ID
>> Name (_SEG, Zero)  // _SEG: PCI Segment
>> Name (_BBN, Zero)  // _BBN: BIOS Bus Number
>> Name (_UID, Zero)  // _UID: Unique ID
>> Name (_STR, Unicode ("PCIe 0 Device"))  // _STR: Description 
>> String
>> Name (_CCA, One)  // _CCA: Cache Coherency Attribute
>> Name (_PRT, Package (0x80)  // _PRT: PCI Routing Table
>> {
>> Package (0x04)
>> {
>> 0x,
>> Zero,
>> L000,
>> Zero
>> },
>>
> Could probably crop this to just leave a representative chunk.
>
>> })
>> Method (_CBA, 0, NotSerialized)  // _CBA: Configuration Base 
>> Address
>> {
>> Return (0x00401000)
>> }
>>
>> Name (_CRS, ResourceTemplate ()  // _CRS: Current Resource 
>> Settings
>> {
>> WordBusNumber (ResourceProducer, MinFixed, MaxFixed, 
>> PosDecode,
>> 0x, // Granularity
>> 0x, // Range Minimum
>> 0x00FF, // Range Maximum
>> 0x, // Translation Offset
>> 0x0100, // Length
>> ,, )
>> DWordMemory (ResourceProducer, PosDecode, MinFixed, 
>> MaxFixed, NonCacheable, ReadWrite,
>> 0x, // Granularity
>> 0x1000, // Range Minimum
>> 0x3EFE, // Range Maximum
>> 0x, // Translation Offset
>> 0x2EFF, // Length
>> 

Re: [PATCH v5 35/36] qtest/bios-tables-test: Generate reference blob for DSDT.hpoffacpiindex

2025-07-03 Thread Jonathan Cameron via
On Thu,  3 Jul 2025 14:35:35 +0200
Eric Auger  wrote:

> The disassembled DSDT table is given below

I'd suggest maybe a spot of cropping to bring this down to a reasonable length.
See inline.

Otherwise LGTM

Reviewed-by: Jonathan Cameron 

> 
>  * Original Table Header:
>  * Signature"DSDT"
>  * Length   0x14E3 (5347)
>  * Revision 0x02
>  * Checksum 0x92
>  * OEM ID   "BOCHS "
>  * OEM Table ID "BXPC"
>  * OEM Revision 0x0001 (1)
>  * Compiler ID  "BXPC"
>  * Compiler Version 0x0001 (1)
>  */
> DefinitionBlock ("", "DSDT", 2, "BOCHS ", "BXPC", 0x0001)
> {
> Scope (\_SB)
> {
> Device (C000)
> {
> Name (_HID, "ACPI0007" /* Processor Device */)  // _HID: Hardware 
> ID
> Name (_UID, Zero)  // _UID: Unique ID
> }
> 
> Device (COM0)
> {
> Name (_HID, "ARMH0011")  // _HID: Hardware ID
> Name (_UID, Zero)  // _UID: Unique ID
> Name (_CRS, ResourceTemplate ()  // _CRS: Current Resource 
> Settings
> {
> Memory32Fixed (ReadWrite,
> 0x0900, // Address Base
> 0x1000, // Address Length
> )
> Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive, ,, 
> )
> {
> 0x0021,
> }
> })
> }
> 
> Device (FWCF)
> {
> Name (_HID, "QEMU0002")  // _HID: Hardware ID
> Name (_STA, 0x0B)  // _STA: Status
> Name (_CCA, One)  // _CCA: Cache Coherency Attribute
> Name (_CRS, ResourceTemplate ()  // _CRS: Current Resource 
> Settings
> {
> Memory32Fixed (ReadWrite,
> 0x0902, // Address Base
> 0x0018, // Address Length
> )
> })
> }
> 
> Device (VR00)
> {
> Name (_HID, "LNRO0005")  // _HID: Hardware ID
> Name (_UID, Zero)  // _UID: Unique ID
> Name (_CCA, One)  // _CCA: Cache Coherency Attribute
> Name (_CRS, ResourceTemplate ()  // _CRS: Current Resource 
> Settings
> {
> Memory32Fixed (ReadWrite,
> 0x0A00, // Address Base
> 0x0200, // Address Length
> )
> Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive, ,, 
> )
> {
> 0x0030,
> }
> })
> }
If you want to keep these, maybe a single representative LNRO0005 only.

> 
> Device (PCI0)
> {
> Name (_HID, "PNP0A08" /* PCI Express Bus */)  // _HID: Hardware ID
> Name (_CID, "PNP0A03" /* PCI Bus */)  // _CID: Compatible ID
> Name (_SEG, Zero)  // _SEG: PCI Segment
> Name (_BBN, Zero)  // _BBN: BIOS Bus Number
> Name (_UID, Zero)  // _UID: Unique ID
> Name (_STR, Unicode ("PCIe 0 Device"))  // _STR: Description 
> String
> Name (_CCA, One)  // _CCA: Cache Coherency Attribute
> Name (_PRT, Package (0x80)  // _PRT: PCI Routing Table
> {
> Package (0x04)
> {
> 0x,
> Zero,
> L000,
> Zero
> },
> 

Could probably crop this to just leave a representative chunk.

> })
> Method (_CBA, 0, NotSerialized)  // _CBA: Configuration Base 
> Address
> {
> Return (0x00401000)
> }
> 
> Name (_CRS, ResourceTemplate ()  // _CRS: Current Resource 
> Settings
> {
> WordBusNumber (ResourceProducer, MinFixed, MaxFixed, 
> PosDecode,
> 0x, // Granularity
> 0x, // Range Minimum
> 0x00FF, // Range Maximum
> 0x, // Translation Offset
> 0x0100, // Length
> ,, )
> DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed, 
> NonCacheable, ReadWrite,
> 0x, // Granularity
> 0x1000, // Range Minimum
> 0x3EFE, // Range Maximum
> 0x, // Translation Offset
> 0x2EFF, // Length
> ,, , AddressRangeMemory, TypeStatic)
> DWordIO (ResourceProducer, MinFixed, MaxFixed, PosDecode, 
> EntireRange,
> 0x, // Granularity
> 0x,   

[PATCH v5 35/36] qtest/bios-tables-test: Generate reference blob for DSDT.hpoffacpiindex

2025-07-03 Thread Eric Auger
The disassembled DSDT table is given below

 * Original Table Header:
 * Signature"DSDT"
 * Length   0x14E3 (5347)
 * Revision 0x02
 * Checksum 0x92
 * OEM ID   "BOCHS "
 * OEM Table ID "BXPC"
 * OEM Revision 0x0001 (1)
 * Compiler ID  "BXPC"
 * Compiler Version 0x0001 (1)
 */
DefinitionBlock ("", "DSDT", 2, "BOCHS ", "BXPC", 0x0001)
{
Scope (\_SB)
{
Device (C000)
{
Name (_HID, "ACPI0007" /* Processor Device */)  // _HID: Hardware ID
Name (_UID, Zero)  // _UID: Unique ID
}

Device (COM0)
{
Name (_HID, "ARMH0011")  // _HID: Hardware ID
Name (_UID, Zero)  // _UID: Unique ID
Name (_CRS, ResourceTemplate ()  // _CRS: Current Resource Settings
{
Memory32Fixed (ReadWrite,
0x0900, // Address Base
0x1000, // Address Length
)
Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive, ,, )
{
0x0021,
}
})
}

Device (FWCF)
{
Name (_HID, "QEMU0002")  // _HID: Hardware ID
Name (_STA, 0x0B)  // _STA: Status
Name (_CCA, One)  // _CCA: Cache Coherency Attribute
Name (_CRS, ResourceTemplate ()  // _CRS: Current Resource Settings
{
Memory32Fixed (ReadWrite,
0x0902, // Address Base
0x0018, // Address Length
)
})
}

Device (VR00)
{
Name (_HID, "LNRO0005")  // _HID: Hardware ID
Name (_UID, Zero)  // _UID: Unique ID
Name (_CCA, One)  // _CCA: Cache Coherency Attribute
Name (_CRS, ResourceTemplate ()  // _CRS: Current Resource Settings
{
Memory32Fixed (ReadWrite,
0x0A00, // Address Base
0x0200, // Address Length
)
Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive, ,, )
{
0x0030,
}
})
}

Device (VR01)
{
Name (_HID, "LNRO0005")  // _HID: Hardware ID
Name (_UID, One)  // _UID: Unique ID
Name (_CCA, One)  // _CCA: Cache Coherency Attribute
Name (_CRS, ResourceTemplate ()  // _CRS: Current Resource Settings
{
Memory32Fixed (ReadWrite,
0x0A000200, // Address Base
0x0200, // Address Length
)
Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive, ,, )
{
0x0031,
}
})
}

Device (VR02)
{
Name (_HID, "LNRO0005")  // _HID: Hardware ID
Name (_UID, 0x02)  // _UID: Unique ID
Name (_CCA, One)  // _CCA: Cache Coherency Attribute
Name (_CRS, ResourceTemplate ()  // _CRS: Current Resource Settings
{
Memory32Fixed (ReadWrite,
0x0A000400, // Address Base
0x0200, // Address Length
)
Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive, ,, )
{
0x0032,
}
})
}

Device (VR03)
{
Name (_HID, "LNRO0005")  // _HID: Hardware ID
Name (_UID, 0x03)  // _UID: Unique ID
Name (_CCA, One)  // _CCA: Cache Coherency Attribute
Name (_CRS, ResourceTemplate ()  // _CRS: Current Resource Settings
{
Memory32Fixed (ReadWrite,
0x0A000600, // Address Base
0x0200, // Address Length
)
Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive, ,, )
{
0x0033,
}
})
}

Device (VR04)
{
Name (_HID, "LNRO0005")  // _HID: Hardware ID
Name (_UID, 0x04)  // _UID: Unique ID
Name (_CCA, One)  // _CCA: Cache Coherency Attribute
Name (_CRS, ResourceTemplate ()  // _CRS: Current Resource Settings
{
Memory32Fixed (ReadWrite,
0x0A000800, // Address Base
0x0200, // Address Length
)
Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive, ,, )
{
0x0034,
}
})
}

Devi