Re: [PATCH v6 29/36] hw/acpi/ged: Support migration of AcpiPciHpState

2025-07-09 Thread Prasad Pandit
On Wed, 9 Jul 2025 at 01:30, Eric Auger  wrote:
> Add a subsection to migrate the AcpiPciHpState state.
>
> Signed-off-by: Eric Auger 
> Reviewed-by: Igor Mammedov 
> Reviewed-by: Jonathan Cameron 
> ---
>  hw/acpi/generic_event_device.c | 20 
>  1 file changed, 20 insertions(+)
>
> diff --git a/hw/acpi/generic_event_device.c b/hw/acpi/generic_event_device.c
> index 7535d07737..95682b79a2 100644
> --- a/hw/acpi/generic_event_device.c
> +++ b/hw/acpi/generic_event_device.c
> @@ -417,6 +417,25 @@ static const VMStateDescription vmstate_ghes_state = {
>  }
>  };
>
> +static bool pcihp_needed(void *opaque)
> +{
> +AcpiGedState *s = opaque;
> +return s->pcihp_state.use_acpi_hotplug_bridge;
> +}
> +
> +static const VMStateDescription vmstate_pcihp_state = {
> +.name = "acpi-ged/pcihp",
> +.version_id = 1,
> +.minimum_version_id = 1,
> +.needed = pcihp_needed,
> +.fields = (const VMStateField[]) {
> +VMSTATE_PCI_HOTPLUG(pcihp_state,
> +AcpiGedState,
> +NULL, NULL),
> +VMSTATE_END_OF_LIST()
> +}
> +};
> +
>  static const VMStateDescription vmstate_acpi_ged = {
>  .name = "acpi-ged",
>  .version_id = 1,
> @@ -429,6 +448,7 @@ static const VMStateDescription vmstate_acpi_ged = {
>  &vmstate_memhp_state,
>  &vmstate_cpuhp_state,
>  &vmstate_ghes_state,
> +&vmstate_pcihp_state,
>  NULL
>  }
>  };
> --

Looks okay.
Reviewed-by: Prasad Pandit 

Thank you.
---
  - Prasad




[PATCH v6 29/36] hw/acpi/ged: Support migration of AcpiPciHpState

2025-07-08 Thread Eric Auger
Add a subsection to migrate the AcpiPciHpState state.

Signed-off-by: Eric Auger 
Reviewed-by: Igor Mammedov 
Reviewed-by: Jonathan Cameron 
---
 hw/acpi/generic_event_device.c | 20 
 1 file changed, 20 insertions(+)

diff --git a/hw/acpi/generic_event_device.c b/hw/acpi/generic_event_device.c
index 7535d07737..95682b79a2 100644
--- a/hw/acpi/generic_event_device.c
+++ b/hw/acpi/generic_event_device.c
@@ -417,6 +417,25 @@ static const VMStateDescription vmstate_ghes_state = {
 }
 };
 
+static bool pcihp_needed(void *opaque)
+{
+AcpiGedState *s = opaque;
+return s->pcihp_state.use_acpi_hotplug_bridge;
+}
+
+static const VMStateDescription vmstate_pcihp_state = {
+.name = "acpi-ged/pcihp",
+.version_id = 1,
+.minimum_version_id = 1,
+.needed = pcihp_needed,
+.fields = (const VMStateField[]) {
+VMSTATE_PCI_HOTPLUG(pcihp_state,
+AcpiGedState,
+NULL, NULL),
+VMSTATE_END_OF_LIST()
+}
+};
+
 static const VMStateDescription vmstate_acpi_ged = {
 .name = "acpi-ged",
 .version_id = 1,
@@ -429,6 +448,7 @@ static const VMStateDescription vmstate_acpi_ged = {
 &vmstate_memhp_state,
 &vmstate_cpuhp_state,
 &vmstate_ghes_state,
+&vmstate_pcihp_state,
 NULL
 }
 };
-- 
2.49.0