[Qemu-devel] [Bug 1625987] Re: target-arm/translate-a64.c:2028: possible coding error ?
Released with v2.8 ** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1625987 Title: target-arm/translate-a64.c:2028: possible coding error ? Status in QEMU: Fix Released Bug description: target-arm/translate-a64.c:2028:37: warning: ?: using integer constants in boolean context [-Wint-in-bool-context] Source code is bool iss_sf = opc == 0 ? 32 : 64; Maybe better code bool iss_sf = (opc == 0) ? 32 : 64; To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1625987/+subscriptions
[Qemu-devel] [Bug 1625987] Re: target-arm/translate-a64.c:2028: possible coding error ?
Now fixed in master, commit 173ff58580b383a7841. ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1625987 Title: target-arm/translate-a64.c:2028: possible coding error ? Status in QEMU: Fix Committed Bug description: target-arm/translate-a64.c:2028:37: warning: ?: using integer constants in boolean context [-Wint-in-bool-context] Source code is bool iss_sf = opc == 0 ? 32 : 64; Maybe better code bool iss_sf = (opc == 0) ? 32 : 64; To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1625987/+subscriptions
Re: [Qemu-devel] [Bug 1625987] Re: target-arm/translate-a64.c:2028: possible coding error ?
On Thu, Sep 29, 2016 at 06:40:53PM -0700, Peter Maydell wrote: > On 22 September 2016 at 02:53, Peter Maydell wrote: > > This is clearly a bug, but your suggested change won't deal with the > > problem, which is that we're trying to set a bool so the ? 32 : 64 > > construct is just wrong. > > > Bug description: > > target-arm/translate-a64.c:2028:37: warning: ?: using integer > > constants in boolean context [-Wint-in-bool-context] > > > > Source code is > > > > bool iss_sf = opc == 0 ? 32 : 64; > > Edgar, did you want to look at a fix for this? It was introduced > in your commit aaa1f954d4 adding syndrome info for loads and stores. Hi Peter, Yes, I've just posted a fix to the list. It should have been: bool iss_sf = opc == 0 ? false : true; Cheers, Edgar
Re: [Qemu-devel] [Bug 1625987] Re: target-arm/translate-a64.c:2028: possible coding error ?
On 22 September 2016 at 02:53, Peter Maydell wrote: > This is clearly a bug, but your suggested change won't deal with the > problem, which is that we're trying to set a bool so the ? 32 : 64 > construct is just wrong. > Bug description: > target-arm/translate-a64.c:2028:37: warning: ?: using integer > constants in boolean context [-Wint-in-bool-context] > > Source code is > > bool iss_sf = opc == 0 ? 32 : 64; Edgar, did you want to look at a fix for this? It was introduced in your commit aaa1f954d4 adding syndrome info for loads and stores. thanks -- PMM
[Qemu-devel] [Bug 1625987] Re: target-arm/translate-a64.c:2028: possible coding error ?
This is clearly a bug, but your suggested change won't deal with the problem, which is that we're trying to set a bool so the ? 32 : 64 construct is just wrong. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1625987 Title: target-arm/translate-a64.c:2028: possible coding error ? Status in QEMU: New Bug description: target-arm/translate-a64.c:2028:37: warning: ?: using integer constants in boolean context [-Wint-in-bool-context] Source code is bool iss_sf = opc == 0 ? 32 : 64; Maybe better code bool iss_sf = (opc == 0) ? 32 : 64; To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1625987/+subscriptions
