Re: [Qemu-devel] [PATCH] linux-user: Fix s390x safe-syscall for z900

[Thomas Huth]

On 18.10.2016 18:42, Richard Henderson wrote:
> The LT instruction was added in the extended immediate facility
> introduced with the z9-109 processor.
> 
> Reported-by: Michael Tokarev 
> Fixes: c9bc3437a905b660561a26cd4ecc64579843267b
> Signed-off-by: Richard Henderson 
> ---
>  linux-user/host/s390x/safe-syscall.inc.S | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/linux-user/host/s390x/safe-syscall.inc.S 
> b/linux-user/host/s390x/safe-syscall.inc.S
> index f1b446a..61d75dc 100644
> --- a/linux-user/host/s390x/safe-syscall.inc.S
> +++ b/linux-user/host/s390x/safe-syscall.inc.S
> @@ -72,7 +72,8 @@ safe_syscall_base:
>*/
>  safe_syscall_start:
>   /* if signal_pending is non-zero, don't do the call */
> - lt  %r0,0(%r8)
> + l   %r0,0(%r8)
> + ltr %r0,%r0
>   jne 2f
>   svc 0
>  safe_syscall_end:

Reviewed-by: Thomas Huth 

[Qemu-devel] [PATCH] linux-user: Fix s390x safe-syscall for z900

[Richard Henderson]

The LT instruction was added in the extended immediate facility
introduced with the z9-109 processor.

Reported-by: Michael Tokarev 
Fixes: c9bc3437a905b660561a26cd4ecc64579843267b
Signed-off-by: Richard Henderson 
---
 linux-user/host/s390x/safe-syscall.inc.S | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/linux-user/host/s390x/safe-syscall.inc.S 
b/linux-user/host/s390x/safe-syscall.inc.S
index f1b446a..61d75dc 100644
--- a/linux-user/host/s390x/safe-syscall.inc.S
+++ b/linux-user/host/s390x/safe-syscall.inc.S
@@ -72,7 +72,8 @@ safe_syscall_base:
 */
 safe_syscall_start:
/* if signal_pending is non-zero, don't do the call */
-   lt  %r0,0(%r8)
+   l   %r0,0(%r8)
+   ltr %r0,%r0
jne 2f
svc 0
 safe_syscall_end:
-- 
2.7.4