Re: [Qemu-devel] [PATCH] loader: don't perform overlapping address check for memory region ROM images

2018-02-27 Thread Mark Cave-Ayland
On 23/02/18 18:53, Peter Maydell wrote: I can do, although I don't have any outstanding SPARC patches (just PPC ones for the moment) so it would just be a single commit PR. Is that okay? Yeah, it's less effort for me to apply a pull than a patch in some ways... Done. I've also sent a v2

Re: [Qemu-devel] [PATCH] loader: don't perform overlapping address check for memory region ROM images

2018-02-23 Thread Peter Maydell
On 23 February 2018 at 18:53, Mark Cave-Ayland wrote: > On 23/02/18 18:04, Peter Maydell wrote: > >> On 23 February 2018 at 11:29, Mark Cave-Ayland >> wrote: >>> >>> All memory region ROM images have a base address of 0 which causes

Re: [Qemu-devel] [PATCH] loader: don't perform overlapping address check for memory region ROM images

2018-02-23 Thread Mark Cave-Ayland
On 23/02/18 18:04, Peter Maydell wrote: On 23 February 2018 at 11:29, Mark Cave-Ayland wrote: All memory region ROM images have a base address of 0 which causes the overlapping address check to fail if more than one memory region ROM image is present, or an

Re: [Qemu-devel] [PATCH] loader: don't perform overlapping address check for memory region ROM images

2018-02-23 Thread Peter Maydell
On 23 February 2018 at 11:29, Mark Cave-Ayland wrote: > All memory region ROM images have a base address of 0 which causes the > overlapping > address check to fail if more than one memory region ROM image is present, or > an > existing ROM image is loaded at

[Qemu-devel] [PATCH] loader: don't perform overlapping address check for memory region ROM images

2018-02-23 Thread Mark Cave-Ayland
All memory region ROM images have a base address of 0 which causes the overlapping address check to fail if more than one memory region ROM image is present, or an existing ROM image is loaded at address 0. Make sure that we ignore the overlapping address check in rom_check_and_register_reset()