Re: [Qemu-devel] [PATCH] mcf_fec: fix error in qemu_send_packet argument

2016-09-22 Thread Jason Wang 



On 2016年09月22日 22:28, Paolo Bonzini wrote:

This uses the wrong frame size for packets composed of multiple
descriptors.

Signed-off-by: Paolo Bonzini 
---
  hw/net/mcf_fec.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/net/mcf_fec.c b/hw/net/mcf_fec.c
index 0ee8ad9..5a5fc69 100644
--- a/hw/net/mcf_fec.c
+++ b/hw/net/mcf_fec.c
@@ -176,7 +176,7 @@ static void mcf_fec_do_tx(mcf_fec_state *s)
  if (bd.flags & FEC_BD_L) {
  /* Last buffer in frame.  */
  DPRINTF("Sending packet\n");
-qemu_send_packet(qemu_get_queue(s->nic), frame, len);
+qemu_send_packet(qemu_get_queue(s->nic), frame, frame_size);
  ptr = frame;
  frame_size = 0;
  s->eir |= FEC_INT_TXF;


Applied, thanks.

[Qemu-devel] [PATCH] mcf_fec: fix error in qemu_send_packet argument

2016-09-22 Thread Paolo Bonzini 
This uses the wrong frame size for packets composed of multiple
descriptors.

Signed-off-by: Paolo Bonzini 
---
 hw/net/mcf_fec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/net/mcf_fec.c b/hw/net/mcf_fec.c
index 0ee8ad9..5a5fc69 100644
--- a/hw/net/mcf_fec.c
+++ b/hw/net/mcf_fec.c
@@ -176,7 +176,7 @@ static void mcf_fec_do_tx(mcf_fec_state *s)
 if (bd.flags & FEC_BD_L) {
 /* Last buffer in frame.  */
 DPRINTF("Sending packet\n");
-qemu_send_packet(qemu_get_queue(s->nic), frame, len);
+qemu_send_packet(qemu_get_queue(s->nic), frame, frame_size);
 ptr = frame;
 frame_size = 0;
 s->eir |= FEC_INT_TXF;
-- 
2.7.4