Re: [Qemu-devel] [PATCH] scripts/hxtool: fix undefined behavour of echo

2016-10-16 Thread Daniel Shahaf
Michael Tokarev wrote on Sun, Oct 16, 2016 at 17:30:28 +0300: > From: Daniel Shahaf > > Avoid undefined behaviour of echo(1) with backslashes in arguments > The behaviour is implementation-defined, different /bin/sh's behave > differently. > Signed-off-by: Daniel Shahaf

Re: [Qemu-devel] [PATCH] scripts/hxtool: fix undefined behavour of echo

2016-10-16 Thread Michael Tokarev
16.10.2016 18:22, Daniel Shahaf wrote: > Signed-off-by: Daniel Shahaf > Like this? Yes, exactly, thank you! :) /mjt

Re: [Qemu-devel] [PATCH] scripts/hxtool: fix undefined behavour of echo

2016-10-16 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1476628228-7425-1-git-send-email-...@msgid.tls.msk.ru Subject: [Qemu-devel] [PATCH] scripts/hxtool: fix undefined behavour of echo === TEST SCRIPT BEGIN === #!/bin/bash

[Qemu-devel] [PATCH] scripts/hxtool: fix undefined behavour of echo

2016-10-16 Thread Michael Tokarev
From: Daniel Shahaf Avoid undefined behaviour of echo(1) with backslashes in arguments The behaviour is implementation-defined, different /bin/sh's behave differently. Signed-off-By: Michael Tokarev --- Submitting this patch upstream, thank you very much!