Re: [Qemu-devel] [PATCH] target/arm: Correct load/store exclusive pairing and alignment

2017-08-14 Thread Alistair Francis
On Sat, Aug 12, 2017 at 8:41 AM, Richard Henderson wrote: > SetExclusiveMonitors in the pseudocode is on the address + width, > and says nothing about the manner of the load. Therefore > > ldxpw0, w1, [x2] > vs > ldxrx0, [x2] > > must record the same

Re: [Qemu-devel] [PATCH] target/arm: Correct load/store exclusive pairing and alignment

2017-08-12 Thread Richard Henderson
On 08/12/2017 09:29 AM, Alistair Francis wrote: > Now we aren't ever checking cpu_exclusive_high. Is it even worth having? We are checking cpu_exclusive_high for 64-bit STXP. See paired_cmpxchg64_{l,b}e in target/arm/helper-a64.c. r~

Re: [Qemu-devel] [PATCH] target/arm: Correct load/store exclusive pairing and alignment

2017-08-12 Thread Alistair Francis
On Sat, Aug 12, 2017 at 8:41 AM, Richard Henderson wrote: > SetExclusiveMonitors in the pseudocode is on the address + width, > and says nothing about the manner of the load. Therefore > > ldxpw0, w1, [x2] > vs > ldxrx0, [x2] > > must record the same

[Qemu-devel] [PATCH] target/arm: Correct load/store exclusive pairing and alignment

2017-08-12 Thread Richard Henderson
SetExclusiveMonitors in the pseudocode is on the address + width, and says nothing about the manner of the load. Therefore ldxpw0, w1, [x2] vs ldxrx0, [x2] must record the same metadata so that either may pair with stxpw3, w0, w1, [x2] vs stxrw3,