Re: [Qemu-devel] [PATCH] target-lm32: fix style issue

2016-10-15 Thread Michael Tokarev
12.10.2016 19:23, Michael Walle wrote: Both branches of the ternary operator have the same expressions. Drop the operator. Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [PATCH] target-lm32: fix style issue

2016-10-12 Thread Peter Maydell
On 12 October 2016 at 18:11, Michael Walle wrote: > Am 2016-10-12 18:35, schrieb Peter Maydell: >> but I noticed while doing the review that our LOG_DIS >> is wrong for the compare-immediates: >> >> LOG_DIS("cmpei r%d, r%d, %d\n", dc->r0, dc->r1, >> sign_extend(dc->imm16, 1

Re: [Qemu-devel] [PATCH] target-lm32: fix style issue

2016-10-12 Thread Peter Maydell
On 12 October 2016 at 17:42, Michael Walle wrote: > Am 2016-10-12 18:35, schrieb Peter Maydell: >> >> but I noticed while doing the review that our LOG_DIS >> is wrong for the compare-immediates: >> >> LOG_DIS("cmpei r%d, r%d, %d\n", dc->r0, dc->r1, >> sign_extend(dc->imm16

Re: [Qemu-devel] [PATCH] target-lm32: fix style issue

2016-10-12 Thread Michael Walle
Am 2016-10-12 18:35, schrieb Peter Maydell: On 12 October 2016 at 17:23, Michael Walle wrote: Both branches of the ternary operator have the same expressions. Drop the operator. This fixes: https://bugs.launchpad.net/qemu/+bug/1414293 Signed-off-by: Michael Walle --- target-lm32/translate.

Re: [Qemu-devel] [PATCH] target-lm32: fix style issue

2016-10-12 Thread Michael Walle
Am 2016-10-12 18:35, schrieb Peter Maydell: but I noticed while doing the review that our LOG_DIS is wrong for the compare-immediates: LOG_DIS("cmpei r%d, r%d, %d\n", dc->r0, dc->r1, sign_extend(dc->imm16, 16)); but the processor reference manual says cmpei's mnemonic sh

Re: [Qemu-devel] [PATCH] target-lm32: fix style issue

2016-10-12 Thread Peter Maydell
On 12 October 2016 at 17:23, Michael Walle wrote: > Both branches of the ternary operator have the same expressions. Drop the > operator. > > This fixes: https://bugs.launchpad.net/qemu/+bug/1414293 > > Signed-off-by: Michael Walle > --- > target-lm32/translate.c | 2 +- > 1 file changed, 1 inse

Re: [Qemu-devel] [PATCH] target-lm32: fix style issue

2016-10-12 Thread Thomas Huth
On 12.10.2016 18:23, Michael Walle wrote: > Both branches of the ternary operator have the same expressions. Drop the > operator. > > This fixes: https://bugs.launchpad.net/qemu/+bug/1414293 > > Signed-off-by: Michael Walle > --- > target-lm32/translate.c | 2 +- > 1 file changed, 1 insertion(+

[Qemu-devel] [PATCH] target-lm32: fix style issue

2016-10-12 Thread Michael Walle
Both branches of the ternary operator have the same expressions. Drop the operator. This fixes: https://bugs.launchpad.net/qemu/+bug/1414293 Signed-off-by: Michael Walle --- target-lm32/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-lm32/translate.c b/tar