Re: [Qemu-devel] [PATCH] tests/qmp-test: Add generic, basic test of query commands

2017-09-01 Thread Markus Armbruster
Thomas Huth writes: > On 11.08.2017 11:08, Markus Armbruster wrote: >> Eric Blake writes: >> >>> On 08/10/2017 01:30 PM, Markus Armbruster wrote: > [...] We get basic test coverage for the following commands: >>> >>> Cool! >>> qom-list-types query-acpi-ospm-status >>

Re: [Qemu-devel] [PATCH] tests/qmp-test: Add generic, basic test of query commands

2017-09-01 Thread Thomas Huth
On 11.08.2017 11:08, Markus Armbruster wrote: > Eric Blake writes: > >> On 08/10/2017 01:30 PM, Markus Armbruster wrote: [...] >>> We get basic test coverage for the following commands: >> >> Cool! >> >>> >>> qom-list-types >>> query-acpi-ospm-status >>> query-balloon (e

Re: [Qemu-devel] [PATCH] tests/qmp-test: Add generic, basic test of query commands

2017-08-11 Thread Markus Armbruster
Eric Blake writes: > On 08/10/2017 01:30 PM, Markus Armbruster wrote: >> A command is a query if it has no side effect and yields a result. >> Such commands are typically named query-FOO, but there are exceptions. >> >> The basic idea is to find candidates with query-qmp-schema, filter out >> th

Re: [Qemu-devel] [PATCH] tests/qmp-test: Add generic, basic test of query commands

2017-08-10 Thread Eric Blake
On 08/10/2017 01:30 PM, Markus Armbruster wrote: > A command is a query if it has no side effect and yields a result. > Such commands are typically named query-FOO, but there are exceptions. > > The basic idea is to find candidates with query-qmp-schema, filter out > the ones that aren't queries w

[Qemu-devel] [PATCH] tests/qmp-test: Add generic, basic test of query commands

2017-08-10 Thread Markus Armbruster
A command is a query if it has no side effect and yields a result. Such commands are typically named query-FOO, but there are exceptions. The basic idea is to find candidates with query-qmp-schema, filter out the ones that aren't queries with an explicit blacklist, and test the remaining ones agai