Re: [Qemu-devel] [PATCH] virtio-gpu: fix memory leak in virtio_gpu_resource_create_2d
On So, 2016-09-18 at 19:07 -0700, Li Qiang wrote: > From: Li Qiang> > In virtio gpu resource create dispatch, if the pixman format is zero > it doesn't free the resource object allocated previously. Thus leading > a host memory leak issue. This patch avoid this. > > Signed-off-by: Li Qiang Added to vga queue. thanks, Gerd
Re: [Qemu-devel] [PATCH] virtio-gpu: fix memory leak in virtio_gpu_resource_create_2d
On Mon, Sep 19, 2016 at 6:08 AM Li Qiangwrote: > From: Li Qiang > > In virtio gpu resource create dispatch, if the pixman format is zero > it doesn't free the resource object allocated previously. Thus leading > a host memory leak issue. This patch avoid this. > > Signed-off-by: Li Qiang > Reviewed-by: Marc-André Lureau --- > hw/display/virtio-gpu.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c > index 7fe6ed8..5b6d17b 100644 > --- a/hw/display/virtio-gpu.c > +++ b/hw/display/virtio-gpu.c > @@ -333,6 +333,7 @@ static void virtio_gpu_resource_create_2d(VirtIOGPU *g, > qemu_log_mask(LOG_GUEST_ERROR, >"%s: host couldn't handle guest format %d\n", >__func__, c2d.format); > +g_free(res); > cmd->error = VIRTIO_GPU_RESP_ERR_INVALID_PARAMETER; > return; > } > -- > 1.8.3.1 > > > -- Marc-André Lureau
[Qemu-devel] [PATCH] virtio-gpu: fix memory leak in virtio_gpu_resource_create_2d
From: Li QiangIn virtio gpu resource create dispatch, if the pixman format is zero it doesn't free the resource object allocated previously. Thus leading a host memory leak issue. This patch avoid this. Signed-off-by: Li Qiang --- hw/display/virtio-gpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c index 7fe6ed8..5b6d17b 100644 --- a/hw/display/virtio-gpu.c +++ b/hw/display/virtio-gpu.c @@ -333,6 +333,7 @@ static void virtio_gpu_resource_create_2d(VirtIOGPU *g, qemu_log_mask(LOG_GUEST_ERROR, "%s: host couldn't handle guest format %d\n", __func__, c2d.format); +g_free(res); cmd->error = VIRTIO_GPU_RESP_ERR_INVALID_PARAMETER; return; } -- 1.8.3.1