Re: [Qemu-devel] [PATCH] x86: ioapic: boost default version to 0x20

[Paolo Bonzini]

On 22/09/2016 10:36, Peter Xu wrote:
> It's 2.8 now, and maybe it's time to switch IOAPIC default version to
> 0x20.
> 
> Signed-off-by: Peter Xu 
> ---
>  hw/intc/ioapic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/intc/ioapic.c b/hw/intc/ioapic.c
> index 31791b0..fd9208f 100644
> --- a/hw/intc/ioapic.c
> +++ b/hw/intc/ioapic.c
> @@ -416,7 +416,7 @@ static void ioapic_realize(DeviceState *dev, Error **errp)
>  }
>  
>  static Property ioapic_properties[] = {
> -DEFINE_PROP_UINT8("version", IOAPICCommonState, version, 0x11),
> +DEFINE_PROP_UINT8("version", IOAPICCommonState, version, 0x20),
>  DEFINE_PROP_END_OF_LIST(),
>  };

Yes, but you need to set a compat property for 2.7 and earlier machine
types (include/hw/compat.h).

Paolo

[Qemu-devel] [PATCH] x86: ioapic: boost default version to 0x20

[Peter Xu]

It's 2.8 now, and maybe it's time to switch IOAPIC default version to
0x20.

Signed-off-by: Peter Xu 
---
 hw/intc/ioapic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/intc/ioapic.c b/hw/intc/ioapic.c
index 31791b0..fd9208f 100644
--- a/hw/intc/ioapic.c
+++ b/hw/intc/ioapic.c
@@ -416,7 +416,7 @@ static void ioapic_realize(DeviceState *dev, Error **errp)
 }
 
 static Property ioapic_properties[] = {
-DEFINE_PROP_UINT8("version", IOAPICCommonState, version, 0x11),
+DEFINE_PROP_UINT8("version", IOAPICCommonState, version, 0x20),
 DEFINE_PROP_END_OF_LIST(),
 };
 
-- 
2.7.4