Re: [Qemu-devel] [PATCH-for-4.1] hw/block/pflash_cfi02: Explicit switch fallthrough for ERASE commands

2019-07-11 Thread Peter Maydell
On Thu, 11 Jul 2019 at 14:08, Philippe Mathieu-Daudé wrote: > > Previous to commit ddb6f2254, the DQ2 bit was incorrectly set > during PROGRAM command (0xA0). The commit reordered the switch > cases to only set the DQ2 bit for the ERASE commands using a > fallthrough, but did not explicit the

[Qemu-devel] [PATCH-for-4.1] hw/block/pflash_cfi02: Explicit switch fallthrough for ERASE commands

2019-07-11 Thread Philippe Mathieu-Daudé
Previous to commit ddb6f2254, the DQ2 bit was incorrectly set during PROGRAM command (0xA0). The commit reordered the switch cases to only set the DQ2 bit for the ERASE commands using a fallthrough, but did not explicit the fallthrough is intentional. Mark the switch fallthrough with a comment