Re: [Qemu-devel] [PATCH-for-4.2 v2 3/6] s390x/tcg: Flush the TLB of all CPUs on SSKE and RRBE

2019-08-14 Thread David Hildenbrand
On 14.08.19 12:44, Alex Bennée wrote: > > David Hildenbrand writes: > >> On 14.08.19 12:06, Alex Bennée wrote: >>> >>> David Hildenbrand writes: >>> Whenever we modify a storage key, we shuld flush the TLBs of all CPUs, so the MMU fault handling code can properly consider the changed

Re: [Qemu-devel] [PATCH-for-4.2 v2 3/6] s390x/tcg: Flush the TLB of all CPUs on SSKE and RRBE

2019-08-14 Thread Alex Bennée
David Hildenbrand writes: > On 14.08.19 12:06, Alex Bennée wrote: >> >> David Hildenbrand writes: >> >>> Whenever we modify a storage key, we shuld flush the TLBs of all CPUs, >>> so the MMU fault handling code can properly consider the changed storage >>> key (to e.g., properly set the refere

Re: [Qemu-devel] [PATCH-for-4.2 v2 3/6] s390x/tcg: Flush the TLB of all CPUs on SSKE and RRBE

2019-08-14 Thread David Hildenbrand
On 14.08.19 12:06, Alex Bennée wrote: > > David Hildenbrand writes: > >> Whenever we modify a storage key, we shuld flush the TLBs of all CPUs, >> so the MMU fault handling code can properly consider the changed storage >> key (to e.g., properly set the reference and change bit on the next >> ac

Re: [Qemu-devel] [PATCH-for-4.2 v2 3/6] s390x/tcg: Flush the TLB of all CPUs on SSKE and RRBE

2019-08-14 Thread Alex Bennée
David Hildenbrand writes: > Whenever we modify a storage key, we shuld flush the TLBs of all CPUs, > so the MMU fault handling code can properly consider the changed storage > key (to e.g., properly set the reference and change bit on the next > accesses). > > These functions are barely used in

[Qemu-devel] [PATCH-for-4.2 v2 3/6] s390x/tcg: Flush the TLB of all CPUs on SSKE and RRBE

2019-08-14 Thread David Hildenbrand
Whenever we modify a storage key, we shuld flush the TLBs of all CPUs, so the MMU fault handling code can properly consider the changed storage key (to e.g., properly set the reference and change bit on the next accesses). These functions are barely used in modern Linux guests, so the performance