Re: [Qemu-devel] [PATCH 1/1] etsec: fix IRQ (un)masking

2018-07-12 Thread David Gibson
On Thu, Jul 12, 2018 at 02:00:52PM -0700, Michael Davidsaver wrote: > Interrupt conditions occurring while masked are not being > signaled when later unmasked. > The fix is to raise/lower IRQs when IMASK is changed. > > To avoid problems like this in future, consolidate > IRQ pin update logic in o

[Qemu-devel] [PATCH 1/1] etsec: fix IRQ (un)masking

2018-07-12 Thread Michael Davidsaver
Interrupt conditions occurring while masked are not being signaled when later unmasked. The fix is to raise/lower IRQs when IMASK is changed. To avoid problems like this in future, consolidate IRQ pin update logic in one function. Also fix probable typo "IEVENT_TXF | IEVENT_TXF", and update IRQ p