Re: [Qemu-devel] [PATCH 1/2] CODING_STYLE: specify the indent rule for multiline code

2019-02-19 Thread Wei Yang
On Tue, Feb 19, 2019 at 11:52:29AM -0600, Eric Blake wrote: >On 2/18/19 7:31 PM, Wei Yang wrote: >> We didn't specify the indent rule for multiline code here, which may >> misleading users. And in current code, the code use different rules. >> >> Add this rule in CODING_STYLE to make sure this is

Re: [Qemu-devel] [PATCH 1/2] CODING_STYLE: specify the indent rule for multiline code

2019-02-19 Thread Wei Yang
On Tue, Feb 19, 2019 at 11:55:04AM -0600, Eric Blake wrote: >On 2/19/19 11:34 AM, Philippe Mathieu-Daudé wrote: > >> >> What is still unclear is what to do when a function name is over 60 >> characters (you follow a library/API and can not shorten it), for example: >> >> static void

Re: [Qemu-devel] [PATCH 1/2] CODING_STYLE: specify the indent rule for multiline code

2019-02-19 Thread Eric Blake
On 2/19/19 11:34 AM, Philippe Mathieu-Daudé wrote: > > What is still unclear is what to do when a function name is over 60 > characters (you follow a library/API and can not shorten it), for example: > > static void ccid_card_vscard_handle_message(PassthruState *card, > const VSCMsgHeader

Re: [Qemu-devel] [PATCH 1/2] CODING_STYLE: specify the indent rule for multiline code

2019-02-19 Thread Eric Blake
On 2/18/19 7:31 PM, Wei Yang wrote: > We didn't specify the indent rule for multiline code here, which may > misleading users. And in current code, the code use different rules. > > Add this rule in CODING_STYLE to make sure this is clear to every one. > > Signed-off-by: Wei Yang >

Re: [Qemu-devel] [PATCH 1/2] CODING_STYLE: specify the indent rule for multiline code

2019-02-19 Thread Philippe Mathieu-Daudé
Hi, On 2/19/19 2:31 AM, Wei Yang wrote: > We didn't specify the indent rule for multiline code here, which may > misleading users. And in current code, the code use different rules. > > Add this rule in CODING_STYLE to make sure this is clear to every one. > > Signed-off-by: Wei Yang >

[Qemu-devel] [PATCH 1/2] CODING_STYLE: specify the indent rule for multiline code

2019-02-18 Thread Wei Yang
We didn't specify the indent rule for multiline code here, which may misleading users. And in current code, the code use different rules. Add this rule in CODING_STYLE to make sure this is clear to every one. Signed-off-by: Wei Yang Suggested-by: Igor Mammedov --- CODING_STYLE | 26