Re: [Qemu-devel] [PATCH 11/14] nbd/client: Add nbd_receive_export_list()

2018-12-07 Thread Eric Blake
On 12/7/18 4:04 AM, Vladimir Sementsov-Ogievskiy wrote: 01.12.2018 1:03, Eric Blake wrote: We want to be able to detect whether a given qemu NBD server is exposing the right export(s) and dirty bitmaps, at least for regression testing. We could use 'nbd-client -l' from the upstream NBD project

Re: [Qemu-devel] [PATCH 11/14] nbd/client: Add nbd_receive_export_list()

2018-12-07 Thread Vladimir Sementsov-Ogievskiy
01.12.2018 1:03, Eric Blake wrote: > +/* Clean up result of nbd_receive_export_list */ > +void nbd_free_export_list(NBDExportInfo *info, int count) > +{ > +int i, j; personally, I'd prefer explicit if (!info) { return; } here, it's more obvious, and info is unchanging, strange to check

Re: [Qemu-devel] [PATCH 11/14] nbd/client: Add nbd_receive_export_list()

2018-12-07 Thread Vladimir Sementsov-Ogievskiy
01.12.2018 1:03, Eric Blake wrote: > We want to be able to detect whether a given qemu NBD server is > exposing the right export(s) and dirty bitmaps, at least for > regression testing. We could use 'nbd-client -l' from the upstream > NBD project to list exports, but it's annoying to rely on >

Re: [Qemu-devel] [PATCH 11/14] nbd/client: Add nbd_receive_export_list()

2018-12-01 Thread Richard W.M. Jones
On Fri, Nov 30, 2018 at 04:03:40PM -0600, Eric Blake wrote: > We want to be able to detect whether a given qemu NBD server is > exposing the right export(s) and dirty bitmaps, at least for > regression testing. We could use 'nbd-client -l' from the upstream > NBD project to list exports, but it's

[Qemu-devel] [PATCH 11/14] nbd/client: Add nbd_receive_export_list()

2018-11-30 Thread Eric Blake
We want to be able to detect whether a given qemu NBD server is exposing the right export(s) and dirty bitmaps, at least for regression testing. We could use 'nbd-client -l' from the upstream NBD project to list exports, but it's annoying to rely on out-of-tree binaries; furthermore, nbd-client