Re: [Qemu-devel] [PATCH 12/18] iothread: detach all block devices before stopping them

2016-10-14 Thread Paolo Bonzini
On 14/10/2016 16:50, Fam Zheng wrote: >> > +BdrvNextIterator it; >> > + >> > +for (bs = bdrv_first(); bs; bs = bdrv_next()) { >> > +AioContext *ctx = bdrv_get_aio_context(bs); > I have a strong feeling that we should 'continue' if ctx == > qemu_get_aio_context() - otherwise a lot

Re: [Qemu-devel] [PATCH 12/18] iothread: detach all block devices before stopping them

2016-10-14 Thread Fam Zheng
On Thu, 10/13 19:34, Paolo Bonzini wrote: > Soon bdrv_drain will not call aio_poll itself on iothreads. If block > devices are left hanging off the iothread's AioContext, there will be no > one to do I/O for those poor devices. > > Signed-off-by: Paolo Bonzini > --- >

[Qemu-devel] [PATCH 12/18] iothread: detach all block devices before stopping them

2016-10-13 Thread Paolo Bonzini
Soon bdrv_drain will not call aio_poll itself on iothreads. If block devices are left hanging off the iothread's AioContext, there will be no one to do I/O for those poor devices. Signed-off-by: Paolo Bonzini --- iothread.c | 10 ++ 1 file changed, 10 insertions(+)