Re: [Qemu-devel] [PATCH 15/20] tests: New helper qtest_qmp_receive_success()

2018-07-12 Thread Stefan Berger
On 07/12/2018 07:12 AM, Markus Armbruster wrote: Commit b21373d0713 copied wait_command() from tests/migration-test.c to tests/tpm-util.c. Replace both copies by new libqtest helper qtest_qmp_receive_success(). Also use it to simplify qtest_qmp_device_del(). Bonus: gets rid of a non-literal

Re: [Qemu-devel] [PATCH 15/20] tests: New helper qtest_qmp_receive_success()

2018-07-12 Thread Juan Quintela
Markus Armbruster wrote: > Commit b21373d0713 copied wait_command() from tests/migration-test.c > to tests/tpm-util.c. Replace both copies by new libqtest helper > qtest_qmp_receive_success(). Also use it to simplify > qtest_qmp_device_del(). > > Bonus: gets rid of a non-literal format string.

[Qemu-devel] [PATCH 15/20] tests: New helper qtest_qmp_receive_success()

2018-07-12 Thread Markus Armbruster
Commit b21373d0713 copied wait_command() from tests/migration-test.c to tests/tpm-util.c. Replace both copies by new libqtest helper qtest_qmp_receive_success(). Also use it to simplify qtest_qmp_device_del(). Bonus: gets rid of a non-literal format string. A step towards compile-time format