Re: [Qemu-devel] [PATCH 17/56] json: Reject unescaped control characters

2018-08-10 Thread Markus Armbruster
Eric Blake writes: > On 08/08/2018 07:02 AM, Markus Armbruster wrote: >> Fix the lexer to reject unescaped control characters in JSON strings, >> in accordance with RFC 7159. > > Question - can this break existing QMP clients that were relying on > this extension working? In theory, yes. The

Re: [Qemu-devel] [PATCH 17/56] json: Reject unescaped control characters

2018-08-09 Thread Eric Blake
On 08/08/2018 07:02 AM, Markus Armbruster wrote: Fix the lexer to reject unescaped control characters in JSON strings, in accordance with RFC 7159. Question - can this break existing QMP clients that were relying on this extension working? Libvirt used to use libyajl, now it uses

[Qemu-devel] [PATCH 17/56] json: Reject unescaped control characters

2018-08-08 Thread Markus Armbruster
Fix the lexer to reject unescaped control characters in JSON strings, in accordance with RFC 7159. Bonus: we now recover more nicely from unclosed strings. E.g. {"one: 1}\n{"two": 2} now recovers cleanly after the newline, where before the lexer remained confused until the next unpaired