Re: [Qemu-devel] [PATCH 2/2] fpu: Bound increment for scalbn

2018-04-17 Thread Alex Bennée
Richard Henderson writes: > Without bounding the increment, we can overflow exp either here > in scalbn_decomposed or when adding the bias in round_canonical. > This can result in e.g. underflowing to 0 instead of overflowing > to infinity. > > The old softfloat code did bound the increment. > >

Re: [Qemu-devel] [PATCH 2/2] fpu: Bound increment for scalbn

2018-04-17 Thread Peter Maydell
On 17 April 2018 at 14:51, Alex Bennée wrote: > > Richard Henderson writes: > >> Without bounding the increment, we can overflow exp either here >> in scalbn_decomposed or when adding the bias in round_canonical. >> This can result in e.g. underflowing to 0 instead of overflowing >> to infinity.

Re: [Qemu-devel] [PATCH 2/2] fpu: Bound increment for scalbn

2018-04-17 Thread Peter Maydell
On 17 April 2018 at 03:53, Richard Henderson wrote: > Without bounding the increment, we can overflow exp either here > in scalbn_decomposed or when adding the bias in round_canonical. > This can result in e.g. underflowing to 0 instead of overflowing > to infinity. > > The old softfloat code did

[Qemu-devel] [PATCH 2/2] fpu: Bound increment for scalbn

2018-04-16 Thread Richard Henderson
Without bounding the increment, we can overflow exp either here in scalbn_decomposed or when adding the bias in round_canonical. This can result in e.g. underflowing to 0 instead of overflowing to infinity. The old softfloat code did bound the increment. Signed-off-by: Richard Henderson --- fpu