Re: [Qemu-devel] [PATCH 2/2] vl: Partial support for non-scalar properties with -object

2017-08-10 Thread Markus Armbruster
Paolo Bonzini writes: > On 10/08/2017 18:36, Markus Armbruster wrote: +while (!QSIMPLEQ_EMPTY(&oo_queue)) { +ObjectOptionsQueueEntry *e = QSIMPLEQ_FIRST(&oo_queue); + +QSIMPLEQ_REMOVE_HEAD(&oo_queue, entry); +qapi_free_ObjectOptions(e->oo); >>>

Re: [Qemu-devel] [PATCH 2/2] vl: Partial support for non-scalar properties with -object

2017-08-10 Thread Paolo Bonzini
On 10/08/2017 18:36, Markus Armbruster wrote: >>> +while (!QSIMPLEQ_EMPTY(&oo_queue)) { >>> +ObjectOptionsQueueEntry *e = QSIMPLEQ_FIRST(&oo_queue); >>> + >>> +QSIMPLEQ_REMOVE_HEAD(&oo_queue, entry); >>> +qapi_free_ObjectOptions(e->oo); >>> +g_free(e); >>> +}

Re: [Qemu-devel] [PATCH 2/2] vl: Partial support for non-scalar properties with -object

2017-08-10 Thread Markus Armbruster
Paolo Bonzini writes: > On 10/08/2017 14:25, Markus Armbruster wrote: >> We've wanted -object to support non-scalar properties for a while. >> Dan Berrange tried in "[PATCH v4 00/10]Provide a QOM-based >> authorization API". Review led to the conclusion that we need to >> replace rather than add

Re: [Qemu-devel] [PATCH 2/2] vl: Partial support for non-scalar properties with -object

2017-08-10 Thread Markus Armbruster
Eric Blake writes: > On 08/10/2017 07:25 AM, Markus Armbruster wrote: >> We've wanted -object to support non-scalar properties for a while. >> Dan Berrange tried in "[PATCH v4 00/10]Provide a QOM-based >> authorization API". Review led to the conclusion that we need to >> replace rather than add

Re: [Qemu-devel] [PATCH 2/2] vl: Partial support for non-scalar properties with -object

2017-08-10 Thread Paolo Bonzini
On 10/08/2017 14:25, Markus Armbruster wrote: > We've wanted -object to support non-scalar properties for a while. > Dan Berrange tried in "[PATCH v4 00/10]Provide a QOM-based > authorization API". Review led to the conclusion that we need to > replace rather than add to QemuOpts. Initial work to

Re: [Qemu-devel] [PATCH 2/2] vl: Partial support for non-scalar properties with -object

2017-08-10 Thread Eric Blake
On 08/10/2017 07:25 AM, Markus Armbruster wrote: > We've wanted -object to support non-scalar properties for a while. > Dan Berrange tried in "[PATCH v4 00/10]Provide a QOM-based > authorization API". Review led to the conclusion that we need to > replace rather than add to QemuOpts. Initial work

[Qemu-devel] [PATCH 2/2] vl: Partial support for non-scalar properties with -object

2017-08-10 Thread Markus Armbruster
We've wanted -object to support non-scalar properties for a while. Dan Berrange tried in "[PATCH v4 00/10]Provide a QOM-based authorization API". Review led to the conclusion that we need to replace rather than add to QemuOpts. Initial work towards that goal has been merged to provide -blockdev (