On Thu, Mar 12, 2015 at 04:45:17PM +0100, Kevin Wolf wrote:
One issue that I'm finding is that when we move the block-stream
job to an intermediate node, where the device name is empty, we
get messages like Device '' is busy.
My first thought was then make it 'Source/Target device is
On Thu, Mar 12, 2015 at 04:45:17PM +0100, Kevin Wolf wrote:
One issue that I'm finding is that when we move the block-stream
job to an intermediate node, where the device name is empty, we
get messages like Device '' is busy.
I can use node names instead, but they are also not
On Tue, Mar 17, 2015 at 09:22:55AM -0600, Eric Blake wrote:
The BlockJobInfo object returned by query-block-jobs identifies
the owner of the job using the 'device' field. If jobs can be in
any intermediate node then we cannot simply rely on the device
name. We also cannot simply replace
Am 17.03.2015 um 16:00 hat Alberto Garcia geschrieben:
On Thu, Mar 12, 2015 at 04:45:17PM +0100, Kevin Wolf wrote:
One issue that I'm finding is that when we move the block-stream
job to an intermediate node, where the device name is empty, we
get messages like Device '' is busy.
On 03/17/2015 09:00 AM, Alberto Garcia wrote:
The BlockJobInfo object returned by query-block-jobs identifies the
owner of the job using the 'device' field. If jobs can be in any
intermediate node then we cannot simply rely on the device name. We
also cannot simply replace it with a node name
Am 11.03.2015 um 17:38 hat Alberto Garcia geschrieben:
On Thu, Mar 05, 2015 at 03:09:58PM +0100, Kevin Wolf wrote:
{ 'command': 'block-stream',
- 'data': { 'device': 'str', '*base': 'str', '*backing-file': 'str',
-'*speed': 'int', '*on-error': 'BlockdevOnError' } }
+
On Thu, Mar 05, 2015 at 03:09:58PM +0100, Kevin Wolf wrote:
{ 'command': 'block-stream',
- 'data': { 'device': 'str', '*base': 'str', '*backing-file': 'str',
-'*speed': 'int', '*on-error': 'BlockdevOnError' } }
+ 'data': { 'device': 'str', '*base': 'str', '*top': 'str',
+
On Thu, Mar 05, 2015 at 03:09:58PM +0100, Kevin Wolf wrote:
{ 'command': 'block-stream',
- 'data': { 'device': 'str', '*base': 'str', '*backing-file': 'str',
-'*speed': 'int', '*on-error': 'BlockdevOnError' } }
+ 'data': { 'device': 'str', '*base': 'str', '*top': 'str',
+
Am 20.02.2015 um 14:53 hat Alberto Garcia geschrieben:
This adds the 'top' parameter to the 'block-stream' QMP command and
checks that its value is valid before passing it to stream_start().
Signed-off-by: Alberto Garcia be...@igalia.com
--- a/qapi/block-core.json
+++
Kevin Wolf kw...@redhat.com writes:
Am 23.02.2015 um 13:23 hat Alberto Garcia geschrieben:
On Fri, Feb 20, 2015 at 03:38:04PM -0700, Eric Blake wrote:
+if (has_top) {
+top_bs = bdrv_find_backing_image(bs, top);
+if (top_bs == NULL) {
+
On Fri, Feb 20, 2015 at 03:38:04PM -0700, Eric Blake wrote:
+if (has_top) {
+top_bs = bdrv_find_backing_image(bs, top);
+if (top_bs == NULL) {
+error_set(errp, QERR_TOP_NOT_FOUND, top);
+goto out;
+}
If I understand correctly,
Am 23.02.2015 um 13:23 hat Alberto Garcia geschrieben:
On Fri, Feb 20, 2015 at 03:38:04PM -0700, Eric Blake wrote:
+if (has_top) {
+top_bs = bdrv_find_backing_image(bs, top);
+if (top_bs == NULL) {
+error_set(errp, QERR_TOP_NOT_FOUND, top);
+
This adds the 'top' parameter to the 'block-stream' QMP command and
checks that its value is valid before passing it to stream_start().
Signed-off-by: Alberto Garcia be...@igalia.com
---
blockdev.c| 19 +++
hmp.c | 2 +-
On 02/20/2015 06:53 AM, Alberto Garcia wrote:
This adds the 'top' parameter to the 'block-stream' QMP command and
checks that its value is valid before passing it to stream_start().
Signed-off-by: Alberto Garcia be...@igalia.com
---
blockdev.c| 19 +++
14 matches
Mail list logo
