[Qemu-devel] [PATCH 2/3] cpu: implement get_crash_info through QOM properties

[Paolo Bonzini]

Provide a generic implementation for all CPU subclasses.

Reviewed-by: Eric Blake 
Signed-off-by: Paolo Bonzini 
---
 include/qom/cpu.h |  1 -
 qom/cpu.c | 11 ---
 target/i386/cpu.c |  2 +-
 3 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/include/qom/cpu.h b/include/qom/cpu.h
index 1bc3ad2..04d3a2c 100644
--- a/include/qom/cpu.h
+++ b/include/qom/cpu.h
@@ -158,7 +158,6 @@ typedef struct CPUClass {
uint8_t *buf, int len, bool is_write);
 void (*dump_state)(CPUState *cpu, FILE *f, fprintf_function cpu_fprintf,
int flags);
-GuestPanicInformation* (*get_crash_info)(CPUState *cpu);
 void (*dump_statistics)(CPUState *cpu, FILE *f,
 fprintf_function cpu_fprintf, int flags);
 int64_t (*get_arch_id)(CPUState *cpu);
diff --git a/qom/cpu.c b/qom/cpu.c
index 7e005af..a9482ce 100644
--- a/qom/cpu.c
+++ b/qom/cpu.c
@@ -22,6 +22,8 @@
 #include "qapi/error.h"
 #include "qemu-common.h"
 #include "qom/cpu.h"
+#include "qom/qom-qobject.h"
+#include "qapi-visit.h"
 #include "sysemu/hw_accel.h"
 #include "qemu/notify.h"
 #include "qemu/log.h"
@@ -220,13 +222,8 @@ static bool cpu_common_exec_interrupt(CPUState *cpu, int 
int_req)
 
 GuestPanicInformation *cpu_get_crash_info(CPUState *cpu)
 {
-CPUClass *cc = CPU_GET_CLASS(cpu);
-GuestPanicInformation *res = NULL;
-
-if (cc->get_crash_info) {
-res = cc->get_crash_info(cpu);
-}
-return res;
+return OBJECT_PROPERTY_GET_PTR(OBJECT(cpu), "crash-information",
+   GuestPanicInformation, NULL);
 }
 
 void cpu_dump_state(CPUState *cpu, FILE *f, fprintf_function cpu_fprintf,
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 63be816..3071769 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -3516,6 +3516,7 @@ static GuestPanicInformation 
*x86_cpu_get_crash_info(CPUState *cs)
 
 return panic_info;
 }
+
 static void x86_cpu_get_crash_info_qom(Object *obj, Visitor *v,
const char *name, void *opaque,
Error **errp)
@@ -3731,7 +3732,6 @@ static void x86_cpu_common_class_init(ObjectClass *oc, 
void *data)
 cc->do_interrupt = x86_cpu_do_interrupt;
 cc->cpu_exec_interrupt = x86_cpu_exec_interrupt;
 cc->dump_state = x86_cpu_dump_state;
-cc->get_crash_info = x86_cpu_get_crash_info;
 cc->set_pc = x86_cpu_set_pc;
 cc->synchronize_from_tb = x86_cpu_synchronize_from_tb;
 cc->gdb_read_register = x86_cpu_gdb_read_register;
-- 
2.9.3

Re: [Qemu-devel] [PATCH 2/3] cpu: implement get_crash_info through QOM properties

[Eric Blake]

On 02/21/2017 04:42 AM, Paolo Bonzini wrote:
> Provide a generic implementation for all CPU subclasses.
> 
> Signed-off-by: Paolo Bonzini 
> ---
>  include/qom/cpu.h |  1 -
>  qom/cpu.c | 11 ---
>  target/i386/cpu.c |  2 +-
>  3 files changed, 5 insertions(+), 9 deletions(-)

Reviewed-by: Eric Blake 

-- 
Eric Blake   eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org



signature.asc
Description: OpenPGP digital signature

[Qemu-devel] [PATCH 2/3] cpu: implement get_crash_info through QOM properties

[Paolo Bonzini]

Provide a generic implementation for all CPU subclasses.

Signed-off-by: Paolo Bonzini 
---
 include/qom/cpu.h |  1 -
 qom/cpu.c | 11 ---
 target/i386/cpu.c |  2 +-
 3 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/include/qom/cpu.h b/include/qom/cpu.h
index 1bc3ad2..04d3a2c 100644
--- a/include/qom/cpu.h
+++ b/include/qom/cpu.h
@@ -158,7 +158,6 @@ typedef struct CPUClass {
uint8_t *buf, int len, bool is_write);
 void (*dump_state)(CPUState *cpu, FILE *f, fprintf_function cpu_fprintf,
int flags);
-GuestPanicInformation* (*get_crash_info)(CPUState *cpu);
 void (*dump_statistics)(CPUState *cpu, FILE *f,
 fprintf_function cpu_fprintf, int flags);
 int64_t (*get_arch_id)(CPUState *cpu);
diff --git a/qom/cpu.c b/qom/cpu.c
index 7e005af..a9482ce 100644
--- a/qom/cpu.c
+++ b/qom/cpu.c
@@ -22,6 +22,8 @@
 #include "qapi/error.h"
 #include "qemu-common.h"
 #include "qom/cpu.h"
+#include "qom/qom-qobject.h"
+#include "qapi-visit.h"
 #include "sysemu/hw_accel.h"
 #include "qemu/notify.h"
 #include "qemu/log.h"
@@ -220,13 +222,8 @@ static bool cpu_common_exec_interrupt(CPUState *cpu, int 
int_req)
 
 GuestPanicInformation *cpu_get_crash_info(CPUState *cpu)
 {
-CPUClass *cc = CPU_GET_CLASS(cpu);
-GuestPanicInformation *res = NULL;
-
-if (cc->get_crash_info) {
-res = cc->get_crash_info(cpu);
-}
-return res;
+return OBJECT_PROPERTY_GET_PTR(OBJECT(cpu), "crash-information",
+   GuestPanicInformation, NULL);
 }
 
 void cpu_dump_state(CPUState *cpu, FILE *f, fprintf_function cpu_fprintf,
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 63be816..3071769 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -3516,6 +3516,7 @@ static GuestPanicInformation 
*x86_cpu_get_crash_info(CPUState *cs)
 
 return panic_info;
 }
+
 static void x86_cpu_get_crash_info_qom(Object *obj, Visitor *v,
const char *name, void *opaque,
Error **errp)
@@ -3731,7 +3732,6 @@ static void x86_cpu_common_class_init(ObjectClass *oc, 
void *data)
 cc->do_interrupt = x86_cpu_do_interrupt;
 cc->cpu_exec_interrupt = x86_cpu_exec_interrupt;
 cc->dump_state = x86_cpu_dump_state;
-cc->get_crash_info = x86_cpu_get_crash_info;
 cc->set_pc = x86_cpu_set_pc;
 cc->synchronize_from_tb = x86_cpu_synchronize_from_tb;
 cc->gdb_read_register = x86_cpu_gdb_read_register;
-- 
2.9.3