Re: [Qemu-devel] [PATCH 2/3] qapi: clear given pointer

2016-09-21 Thread Daniel P. Berrange
On Wed, Sep 21, 2016 at 11:17:45AM -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > On Wed, Sep 21, 2016 at 02:36:28PM +0400, Marc-André Lureau wrote: > > > Some getters already set *obj argument to NULL early, let's do this for > > > all for consistent behaviour in case o

Re: [Qemu-devel] [PATCH 2/3] qapi: clear given pointer

2016-09-21 Thread Markus Armbruster
Marc-André Lureau writes: > Some getters already set *obj argument to NULL early, let's do this for > all for consistent behaviour in case of errors. > > Signed-off-by: Marc-André Lureau > --- > qapi/qmp-input-visitor.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --gi

Re: [Qemu-devel] [PATCH 2/3] qapi: clear given pointer

2016-09-21 Thread Marc-André Lureau
Hi - Original Message - > On Wed, Sep 21, 2016 at 02:36:28PM +0400, Marc-André Lureau wrote: > > Some getters already set *obj argument to NULL early, let's do this for > > all for consistent behaviour in case of errors. > > > > Signed-off-by: Marc-André Lureau > > If we want consistent

Re: [Qemu-devel] [PATCH 2/3] qapi: clear given pointer

2016-09-21 Thread Daniel P. Berrange
On Wed, Sep 21, 2016 at 02:36:28PM +0400, Marc-André Lureau wrote: > Some getters already set *obj argument to NULL early, let's do this for > all for consistent behaviour in case of errors. > > Signed-off-by: Marc-André Lureau If we want consistent behaviour, there's plenty more visit methods t

Re: [Qemu-devel] [PATCH 2/3] qapi: clear given pointer

2016-09-21 Thread Alberto Garcia
On Wed 21 Sep 2016 12:36:28 PM CEST, Marc-André Lureau wrote: > Some getters already set *obj argument to NULL early, let's do this for > all for consistent behaviour in case of errors. > > Signed-off-by: Marc-André Lureau Reviewed-by: Alberto Garcia Berto

[Qemu-devel] [PATCH 2/3] qapi: clear given pointer

2016-09-21 Thread Marc-André Lureau
Some getters already set *obj argument to NULL early, let's do this for all for consistent behaviour in case of errors. Signed-off-by: Marc-André Lureau --- qapi/qmp-input-visitor.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/qapi/qmp-input-visitor.c b/qapi/qmp-inpu