Re: [Qemu-devel] [PATCH 3/3] xen: perform XenDevice clean-up in XenBus watch handler

2019-09-11 Thread Paul Durrant
> -Original Message- > From: Paul Durrant > Sent: 11 September 2019 15:36 > To: qemu-devel@nongnu.org; xen-de...@lists.xenproject.org > Cc: Paul Durrant ; Stefano Stabellini > ; Anthony > Perard > Subject: [PATCH 3/3] xen: perform XenDevice clean-up in XenBus watch handler > > Cleaning

[Qemu-devel] [PATCH 3/3] xen: perform XenDevice clean-up in XenBus watch handler

2019-09-11 Thread Paul Durrant
Cleaning up offine XenDevice objects directly in xen_device_backend_changed() is dangerous as xen_device_unrealize() will modify the watch list that is being walked. Even the QLIST_FOREACH_SAFE() used in notifier_list_notify() is insufficient as *two* notifiers (for the frontend and backend