Re: [Qemu-devel] [PATCH 4/7] gluster: Add preallocated truncation

2018-02-13 Thread Eric Blake

On 02/13/2018 07:03 AM, Max Reitz wrote:

By using qemu_do_cluster_truncate() in qemu_cluster_truncate(), we now
automatically have preallocated truncation.

Signed-off-by: Max Reitz 
---
  block/gluster.c | 17 +
  1 file changed, 1 insertion(+), 16 deletions(-)



Reviewed-by: Eric Blake 

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.   +1-919-301-3266
Virtualization:  qemu.org | libvirt.org



[Qemu-devel] [PATCH 4/7] gluster: Add preallocated truncation

2018-02-13 Thread Max Reitz
By using qemu_do_cluster_truncate() in qemu_cluster_truncate(), we now
automatically have preallocated truncation.

Signed-off-by: Max Reitz 
---
 block/gluster.c | 17 +
 1 file changed, 1 insertion(+), 16 deletions(-)

diff --git a/block/gluster.c b/block/gluster.c
index 806b894bc8..3f17b7819d 100644
--- a/block/gluster.c
+++ b/block/gluster.c
@@ -1122,23 +1122,8 @@ static coroutine_fn int 
qemu_gluster_co_rw(BlockDriverState *bs,
 static int qemu_gluster_truncate(BlockDriverState *bs, int64_t offset,
  PreallocMode prealloc, Error **errp)
 {
-int ret;
 BDRVGlusterState *s = bs->opaque;
-
-if (prealloc != PREALLOC_MODE_OFF) {
-error_setg(errp, "Unsupported preallocation mode '%s'",
-   PreallocMode_str(prealloc));
-return -ENOTSUP;
-}
-
-ret = glfs_ftruncate(s->fd, offset);
-if (ret < 0) {
-ret = -errno;
-error_setg_errno(errp, -ret, "Failed to truncate file");
-return ret;
-}
-
-return 0;
+return qemu_gluster_do_truncate(s->fd, offset, prealloc, errp);
 }
 
 static coroutine_fn int qemu_gluster_co_readv(BlockDriverState *bs,
-- 
2.14.3