Re: [Qemu-devel] [PATCH 5/8] migration: move calling control_save_page to the common place

2018-03-27 Thread Peter Xu
On Tue, Mar 13, 2018 at 03:57:36PM +0800, guangrong.x...@gmail.com wrote: > From: Xiao Guangrong > > The function is called by both ram_save_page and ram_save_target_page, > so move it to the common caller to cleanup the code > > Signed-off-by: Xiao Guangrong Reviewed-by: Peter Xu -- Peter

Re: [Qemu-devel] [PATCH 5/8] migration: move calling control_save_page to the common place

2018-03-19 Thread Dr. David Alan Gilbert
* Xiao Guangrong (guangrong.x...@gmail.com) wrote: > > > On 03/15/2018 07:47 PM, Dr. David Alan Gilbert wrote: > > > > /* Check the pages is dirty and if it is send it */ > > > if (migration_bitmap_clear_dirty(rs, pss->block, pss->page)) { > > > +RAMBlock *block = pss->block;

Re: [Qemu-devel] [PATCH 5/8] migration: move calling control_save_page to the common place

2018-03-16 Thread Xiao Guangrong
On 03/15/2018 07:47 PM, Dr. David Alan Gilbert wrote: /* Check the pages is dirty and if it is send it */ if (migration_bitmap_clear_dirty(rs, pss->block, pss->page)) { +RAMBlock *block = pss->block; +ram_addr_t offset = pss->page << TARGET_PAGE_BITS; + +if

Re: [Qemu-devel] [PATCH 5/8] migration: move calling control_save_page to the common place

2018-03-15 Thread Dr. David Alan Gilbert
* guangrong.x...@gmail.com (guangrong.x...@gmail.com) wrote: > From: Xiao Guangrong > > The function is called by both ram_save_page and ram_save_target_page, > so move it to the common caller to cleanup the code > > Signed-off-by: Xiao Guangrong > --- > migration/ram.c | 16 >

[Qemu-devel] [PATCH 5/8] migration: move calling control_save_page to the common place

2018-03-13 Thread guangrong . xiao
From: Xiao Guangrong The function is called by both ram_save_page and ram_save_target_page, so move it to the common caller to cleanup the code Signed-off-by: Xiao Guangrong --- migration/ram.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/migration/ram.c