Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 17/17] configure: Support enable/disable COLO feature

2016-10-26 Thread Amit Shah 
On (Wed) 26 Oct 2016 [08:42:27], Eric Blake wrote:
> On 10/26/2016 01:07 AM, Amit Shah wrote:
> > On (Tue) 18 Oct 2016 [20:10:13], zhanghailiang wrote:
> >> configure --enable-colo/--disable-colo to switch COLO
> >> support on/off.
> >> COLO feature is enabled by default.
> >>
> >> Signed-off-by: zhanghailiang 
> >> Signed-off-by: Li Zhijian 
> >> Signed-off-by: Gonglei 
> >> Reviewed-by: Dr. David Alan Gilbert 
> > 
> > Reviewed-by: Amit Shah 
> > 
> >> v19:
> >> - fix colo_supported() to return true
> >> v11:
> >> - Turn COLO on in default (Eric's suggestion)
> > 
> > Can you recap why the suggestion was made to switch it on by default?
> 
> If the feature doesn't depend on external libraries, then enabling
> compilation by default will avoid bitrot.

Yes, that's fair, thanks.

> But mentioning this rationale in the commit message never hurts :)

Yep!



Amit

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 17/17] configure: Support enable/disable COLO feature

2016-10-26 Thread Hailiang Zhang 

On 2016/10/26 21:42, Eric Blake wrote:

On 10/26/2016 01:07 AM, Amit Shah wrote:

On (Tue) 18 Oct 2016 [20:10:13], zhanghailiang wrote:

configure --enable-colo/--disable-colo to switch COLO
support on/off.
COLO feature is enabled by default.

Signed-off-by: zhanghailiang 
Signed-off-by: Li Zhijian 
Signed-off-by: Gonglei 
Reviewed-by: Dr. David Alan Gilbert 


Reviewed-by: Amit Shah 


v19:
- fix colo_supported() to return true
v11:
- Turn COLO on in default (Eric's suggestion)


Can you recap why the suggestion was made to switch it on by default?


If the feature doesn't depend on external libraries, then enabling
compilation by default will avoid bitrot.



I agreed.


But mentioning this rationale in the commit message never hurts :)



Good idea, i'll add this instruction in commit message.
Thank you very much for your speedy reply. :)

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 17/17] configure: Support enable/disable COLO feature

2016-10-26 Thread Hailiang Zhang 

On 2016/10/26 14:07, Amit Shah wrote:

On (Tue) 18 Oct 2016 [20:10:13], zhanghailiang wrote:

configure --enable-colo/--disable-colo to switch COLO
support on/off.
COLO feature is enabled by default.

Signed-off-by: zhanghailiang 
Signed-off-by: Li Zhijian 
Signed-off-by: Gonglei 
Reviewed-by: Dr. David Alan Gilbert 


Reviewed-by: Amit Shah 


v19:
- fix colo_supported() to return true
v11:
- Turn COLO on in default (Eric's suggestion)


Can you recap why the suggestion was made to switch it on by default?



Hmm, this is suggested by Eric long time ago, and he has replied you email
as well. :)



Amit

.

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 17/17] configure: Support enable/disable COLO feature

2016-10-26 Thread Eric Blake 
On 10/26/2016 01:07 AM, Amit Shah wrote:
> On (Tue) 18 Oct 2016 [20:10:13], zhanghailiang wrote:
>> configure --enable-colo/--disable-colo to switch COLO
>> support on/off.
>> COLO feature is enabled by default.
>>
>> Signed-off-by: zhanghailiang 
>> Signed-off-by: Li Zhijian 
>> Signed-off-by: Gonglei 
>> Reviewed-by: Dr. David Alan Gilbert 
> 
> Reviewed-by: Amit Shah 
> 
>> v19:
>> - fix colo_supported() to return true
>> v11:
>> - Turn COLO on in default (Eric's suggestion)
> 
> Can you recap why the suggestion was made to switch it on by default?

If the feature doesn't depend on external libraries, then enabling
compilation by default will avoid bitrot.

But mentioning this rationale in the commit message never hurts :)

-- 
Eric Blake   eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org



signature.asc
Description: OpenPGP digital signature

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 17/17] configure: Support enable/disable COLO feature

2016-10-26 Thread Amit Shah 
On (Tue) 18 Oct 2016 [20:10:13], zhanghailiang wrote:
> configure --enable-colo/--disable-colo to switch COLO
> support on/off.
> COLO feature is enabled by default.
> 
> Signed-off-by: zhanghailiang 
> Signed-off-by: Li Zhijian 
> Signed-off-by: Gonglei 
> Reviewed-by: Dr. David Alan Gilbert 

Reviewed-by: Amit Shah 

> v19:
> - fix colo_supported() to return true
> v11:
> - Turn COLO on in default (Eric's suggestion)

Can you recap why the suggestion was made to switch it on by default?


Amit

[Qemu-devel] [PATCH COLO-Frame (Base) v21 17/17] configure: Support enable/disable COLO feature

2016-10-18 Thread zhanghailiang 
configure --enable-colo/--disable-colo to switch COLO
support on/off.
COLO feature is enabled by default.

Signed-off-by: zhanghailiang 
Signed-off-by: Li Zhijian 
Signed-off-by: Gonglei 
Reviewed-by: Dr. David Alan Gilbert 
---
v19:
- fix colo_supported() to return true
v11:
- Turn COLO on in default (Eric's suggestion)
---
 configure| 11 +++
 migration/colo.c |  2 +-
 2 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/configure b/configure
index dd9e679..6cf3f99 100755
--- a/configure
+++ b/configure
@@ -230,6 +230,7 @@ vhost_net="no"
 vhost_scsi="no"
 vhost_vsock="no"
 kvm="no"
+colo="yes"
 rdma=""
 gprof="no"
 debug_tcg="no"
@@ -918,6 +919,10 @@ for opt do
   ;;
   --enable-kvm) kvm="yes"
   ;;
+  --disable-colo) colo="no"
+  ;;
+  --enable-colo) colo="yes"
+  ;;
   --disable-tcg-interpreter) tcg_interpreter="no"
   ;;
   --enable-tcg-interpreter) tcg_interpreter="yes"
@@ -1363,6 +1368,7 @@ disabled with --disable-FEATURE, default is enabled if 
available:
   fdt fdt device tree
   bluez   bluez stack connectivity
   kvm KVM acceleration support
+  coloCOarse-grain LOck-stepping VM for Non-stop Service
   rdmaRDMA-based migration support
   vde support for vde network
   netmap  support for netmap network
@@ -4911,6 +4917,7 @@ echo "Linux AIO support $linux_aio"
 echo "ATTR/XATTR support $attr"
 echo "Install blobs $blobs"
 echo "KVM support   $kvm"
+echo "COLO support  $colo"
 echo "RDMA support  $rdma"
 echo "TCG interpreter   $tcg_interpreter"
 echo "fdt support   $fdt"
@@ -5532,6 +5539,10 @@ if have_backend "syslog"; then
 fi
 echo "CONFIG_TRACE_FILE=$trace_file" >> $config_host_mak
 
+if test "$colo" = "yes"; then
+  echo "CONFIG_COLO=y" >> $config_host_mak
+fi
+
 if test "$rdma" = "yes" ; then
   echo "CONFIG_RDMA=y" >> $config_host_mak
 fi
diff --git a/migration/colo.c b/migration/colo.c
index 31664e0..a39cd99 100644
--- a/migration/colo.c
+++ b/migration/colo.c
@@ -24,7 +24,7 @@
 
 bool colo_supported(void)
 {
-return false;
+return true;
 }
 
 bool migration_in_colo_state(void)
-- 
1.8.3.1