Re: [Qemu-devel] [PATCH for 3.2 v2 0/7] hw/arm/bcm2835: Add basic support for cprman (clock subsystem)

2018-11-05 Thread no-reply
Hi,

This series failed docker-mingw@fedora build test. Please find the testing 
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

Type: series
Message-id: 20181102001303.32640-1-f4...@amsat.org
Subject: [Qemu-devel] [PATCH for 3.2 v2 0/7] hw/arm/bcm2835: Add basic support 
for cprman (clock subsystem)

=== TEST SCRIPT BEGIN ===
#!/bin/bash
time make docker-test-mingw@fedora SHOW_ENV=1 J=8
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
e88244ce63 MAINTAINERS: Volunteer to review Raspi patches
ccd97451e2 hw/arm/bcm2835: Add basic support for cprman (clock subsystem)
c040413670 hw/arm/bcm2835: Add various unimplemented peripherals
8738d4cc1d hw/arm/bcm2835: Rename some definitions
5cad3a8d3f hw/arm/bcm2835: Use 0x prefix for hex numbers
d5b6b933ad hw/misc/bcm2835_property: Handle the 'domain state' property
14f6bd3c7f MAINTAINERS: Add an entry for the Raspberry Pi machines

=== OUTPUT BEGIN ===
  BUILD   fedora
make[1]: Entering directory '/var/tmp/patchew-tester-tmp-pvww0as4/src'
  GEN 
/var/tmp/patchew-tester-tmp-pvww0as4/src/docker-src.2018-11-05-22.26.31.3469/qemu.tar
Cloning into 
'/var/tmp/patchew-tester-tmp-pvww0as4/src/docker-src.2018-11-05-22.26.31.3469/qemu.tar.vroot'...
done.
Checking out files:  20% (1319/6453)   
Checking out files:  21% (1356/6453)   
Checking out files:  22% (1420/6453)   
Checking out files:  23% (1485/6453)   
Checking out files:  24% (1549/6453)   
Checking out files:  25% (1614/6453)   
Checking out files:  26% (1678/6453)   
Checking out files:  27% (1743/6453)   
Checking out files:  28% (1807/6453)   
Checking out files:  29% (1872/6453)   
Checking out files:  30% (1936/6453)   
Checking out files:  31% (2001/6453)   
Checking out files:  32% (2065/6453)   
Checking out files:  33% (2130/6453)   
Checking out files:  34% (2195/6453)   
Checking out files:  35% (2259/6453)   
Checking out files:  36% (2324/6453)   
Checking out files:  37% (2388/6453)   
Checking out files:  38% (2453/6453)   
Checking out files:  39% (2517/6453)   
Checking out files:  40% (2582/6453)   
Checking out files:  41% (2646/6453)   
Checking out files:  42% (2711/6453)   
Checking out files:  43% (2775/6453)   
Checking out files:  44% (2840/6453)   
Checking out files:  45% (2904/6453)   
Checking out files:  46% (2969/6453)   
Checking out files:  47% (3033/6453)   
Checking out files:  48% (3098/6453)   
Checking out files:  49% (3162/6453)   
Checking out files:  50% (3227/6453)   
Checking out files:  51% (3292/6453)   
Checking out files:  52% (3356/6453)   
Checking out files:  53% (3421/6453)   
Checking out files:  53% (3423/6453)   
Checking out files:  54% (3485/6453)   
Checking out files:  55% (3550/6453)   
Checking out files:  56% (3614/6453)   
Checking out files:  57% (3679/6453)   
Checking out files:  58% (3743/6453)   
Checking out files:  59% (3808/6453)   
Checking out files:  60% (3872/6453)   
Checking out files:  61% (3937/6453)   
Checking out files:  62% (4001/6453)   
Checking out files:  63% (4066/6453)   
Checking out files:  64% (4130/6453)   
Checking out files:  65% (4195/6453)   
Checking out files:  66% (4259/6453)   
Checking out files:  67% (4324/6453)   
Checking out files:  68% (4389/6453)   
Checking out files:  69% (4453/6453)   
Checking out files:  70% (4518/6453)   
Checking out files:  71% (4582/6453)   
Checking out files:  72% (4647/6453)   
Checking out files:  73% (4711/6453)   
Checking out files:  74% (4776/6453)   
Checking out files:  75% (4840/6453)   
Checking out files:  76% (4905/6453)   
Checking out files:  77% (4969/6453)   
Checking out files:  78% (5034/6453)   
Checking out files:  79% (5098/6453)   
Checking out files:  80% (5163/6453)   
Checking out files:  81% (5227/6453)   
Checking out files:  82% (5292/6453)   
Checking out files:  82% (5324/6453)   
Checking out files:  83% (5356/6453)   
Checking out files:  84% (5421/6453)   
Checking out files:  85% (5486/6453)   
Checking out files:  86% (5550/6453)   
Checking out files:  86% (5566/6453)   
Checking out files:  87% (5615/6453)   
Checking out files:  88% (5679/6453)   
Checking out files:  89% (5744/6453)   
Checking out files:  90% (5808/6453)   
Checking out files:  91% (5873/6453)   
Checking out files:  92% (5937/6453)   
Checking out files:  93% (6002/6453)   
Checking out files:  94% (6066/6453)   
Checking out files:  95% (6131/6453)   
Checking out files:  96% (6195/6453)   
Checking out files:  97% (6260/6453)   
Checking out files:  98% (6324/6453)   
Checking out files:  99% (6389/6453)   
Checking out files: 100% (6453/6453)   
Checking out files: 100% (6453/6453), done.
Your branch is up-to-date with 'origin/test'.
Submodule 'dtc' (git://git.qemu-project.org/dtc.git) registered for path 'dtc'
Cloning into 
'/var/tmp/patchew-tester-tmp-pvww0as4/src/docker-src.2018-11-05-22.26.31.3469/qemu.tar.vroot/dtc'...
Submodule path 'dtc': checked out

Re: [Qemu-devel] [PATCH for 3.2 v2 0/7] hw/arm/bcm2835: Add basic support for cprman (clock subsystem)

2018-11-05 Thread Peter Maydell
On 2 November 2018 at 00:12, Philippe Mathieu-Daudé  wrote:
> Hi,
>
> This series is a mix of a previous work I had for the raspi, and a patch from
> Guenter: https://lists.gnu.org/archive/html/qemu-devel/2018-07/msg03153.html
>
> The final patch keep Guenter ideas and comments, but is mostly a rewrite.
> I dropped the A2W code from this work, it doesn't seems unuseful to me.
>
> Guenter can you test this series?
>
> I kept Guenter S-o-b and (C), is that OK? (Guenter?, Peter?)

Yes, that's the general approach the project takes. If you've
made changes to the patches yourself you should note those with
something like
[me: changed foo, bar, baz]
after Guenter's signoff and before your own.

thanks
-- PMM



Re: [Qemu-devel] [PATCH for 3.2 v2 0/7] hw/arm/bcm2835: Add basic support for cprman (clock subsystem)

2018-11-03 Thread no-reply
Hi,

This series failed docker-mingw@fedora build test. Please find the testing 
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

Type: series
Message-id: 20181102001303.32640-1-f4...@amsat.org
Subject: [Qemu-devel] [PATCH for 3.2 v2 0/7] hw/arm/bcm2835: Add basic support 
for cprman (clock subsystem)

=== TEST SCRIPT BEGIN ===
#!/bin/bash
time make docker-test-mingw@fedora SHOW_ENV=1 J=8
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
1997ee7b3b MAINTAINERS: Volunteer to review Raspi patches
5bd4f0ff52 hw/arm/bcm2835: Add basic support for cprman (clock subsystem)
5bb2c51372 hw/arm/bcm2835: Add various unimplemented peripherals
57d232cc31 hw/arm/bcm2835: Rename some definitions
242c2f27ba hw/arm/bcm2835: Use 0x prefix for hex numbers
2316d66248 hw/misc/bcm2835_property: Handle the 'domain state' property
0b73d8ca51 MAINTAINERS: Add an entry for the Raspberry Pi machines

=== OUTPUT BEGIN ===
  BUILD   fedora
make[1]: Entering directory '/var/tmp/patchew-tester-tmp-ujg3tlbv/src'
  GEN 
/var/tmp/patchew-tester-tmp-ujg3tlbv/src/docker-src.2018-11-03-11.31.40.16898/qemu.tar
Cloning into 
'/var/tmp/patchew-tester-tmp-ujg3tlbv/src/docker-src.2018-11-03-11.31.40.16898/qemu.tar.vroot'...
done.
Checking out files:   9% (640/6448)   
Checking out files:  10% (645/6448)   
Checking out files:  11% (710/6448)   
Checking out files:  12% (774/6448)   
Checking out files:  13% (839/6448)   
Checking out files:  14% (903/6448)   
Checking out files:  14% (955/6448)   
Checking out files:  15% (968/6448)   
Checking out files:  16% (1032/6448)   
Checking out files:  17% (1097/6448)   
Checking out files:  18% (1161/6448)   
Checking out files:  19% (1226/6448)   
Checking out files:  19% (1278/6448)   
Checking out files:  20% (1290/6448)   
Checking out files:  21% (1355/6448)   
Checking out files:  22% (1419/6448)   
Checking out files:  23% (1484/6448)   
Checking out files:  24% (1548/6448)   
Checking out files:  25% (1612/6448)   
Checking out files:  26% (1677/6448)   
Checking out files:  27% (1741/6448)   
Checking out files:  28% (1806/6448)   
Checking out files:  29% (1870/6448)   
Checking out files:  30% (1935/6448)   
Checking out files:  31% (1999/6448)   
Checking out files:  32% (2064/6448)   
Checking out files:  33% (2128/6448)   
Checking out files:  34% (2193/6448)   
Checking out files:  35% (2257/6448)   
Checking out files:  36% (2322/6448)   
Checking out files:  37% (2386/6448)   
Checking out files:  38% (2451/6448)   
Checking out files:  39% (2515/6448)   
Checking out files:  39% (2555/6448)   
Checking out files:  40% (2580/6448)   
Checking out files:  41% (2644/6448)   
Checking out files:  42% (2709/6448)   
Checking out files:  43% (2773/6448)   
Checking out files:  44% (2838/6448)   
Checking out files:  45% (2902/6448)   
Checking out files:  46% (2967/6448)   
Checking out files:  47% (3031/6448)   
Checking out files:  48% (3096/6448)   
Checking out files:  49% (3160/6448)   
Checking out files:  50% (3224/6448)   
Checking out files:  51% (3289/6448)   
Checking out files:  52% (3353/6448)   
Checking out files:  53% (3418/6448)   
Checking out files:  54% (3482/6448)   
Checking out files:  55% (3547/6448)   
Checking out files:  56% (3611/6448)   
Checking out files:  57% (3676/6448)   
Checking out files:  58% (3740/6448)   
Checking out files:  59% (3805/6448)   
Checking out files:  60% (3869/6448)   
Checking out files:  61% (3934/6448)   
Checking out files:  62% (3998/6448)   
Checking out files:  63% (4063/6448)   
Checking out files:  64% (4127/6448)   
Checking out files:  65% (4192/6448)   
Checking out files:  66% (4256/6448)   
Checking out files:  67% (4321/6448)   
Checking out files:  68% (4385/6448)   
Checking out files:  69% (4450/6448)   
Checking out files:  70% (4514/6448)   
Checking out files:  71% (4579/6448)   
Checking out files:  72% (4643/6448)   
Checking out files:  73% (4708/6448)   
Checking out files:  74% (4772/6448)   
Checking out files:  75% (4836/6448)   
Checking out files:  76% (4901/6448)   
Checking out files:  77% (4965/6448)   
Checking out files:  78% (5030/6448)   
Checking out files:  79% (5094/6448)   
Checking out files:  80% (5159/6448)   
Checking out files:  81% (5223/6448)   
Checking out files:  82% (5288/6448)   
Checking out files:  83% (5352/6448)   
Checking out files:  84% (5417/6448)   
Checking out files:  85% (5481/6448)   
Checking out files:  86% (5546/6448)   
Checking out files:  87% (5610/6448)   
Checking out files:  88% (5675/6448)   
Checking out files:  89% (5739/6448)   
Checking out files:  90% (5804/6448)   
Checking out files:  91% (5868/6448)   
Checking out files:  92% (5933/6448)   
Checking out files:  93% (5997/6448)   
Checking out files:  94% (6062/6448)   
Checking out files:  95% (6126/6448)   
Checking out files:  96% (6191/6448)   
Checking out files:  97% (6255/6448

Re: [Qemu-devel] [PATCH for 3.2 v2 0/7] hw/arm/bcm2835: Add basic support for cprman (clock subsystem)

2018-11-02 Thread Guenter Roeck

On 11/2/18 12:48 AM, Philippe Mathieu-Daudé wrote:

On Fri, Nov 2, 2018 at 8:32 AM Philippe Mathieu-Daudé  wrote:


Hi Guenter,

On Fri, Nov 2, 2018 at 3:52 AM Guenter Roeck  wrote:


On 11/1/18 5:12 PM, Philippe Mathieu-Daudé wrote:

Hi,

This series is a mix of a previous work I had for the raspi, and a patch from
Guenter: https://lists.gnu.org/archive/html/qemu-devel/2018-07/msg03153.html

The final patch keep Guenter ideas and comments, but is mostly a rewrite.
I dropped the A2W code from this work, it doesn't seems unuseful to me.

Guenter can you test this series?



arm/raspi2 works, but aarch64/raspi3 stalls.


Thanks for testing it!

So I suppose the A2W is required. And I'm probably using a too old kernel,
I'm using the Buster preview following Peter's post [1]:

[0.00] Linux version 4.14.0-3-arm64
(debian-ker...@lists.debian.org) (gcc version 7.2.0 (Debian 7.2.0-18))
#1 SMP Debian 4.14.12-2 (2018-01-06)
[0.00] Machine model: Raspberry Pi 3 Model B
[...]
[8.044215] systemd[1]: Detected architecture arm64.
Welcome to Debian GNU/Linux buster/sid!

Debian GNU/Linux buster/sid rpi3 ttyAMA0

rpi3 login: root
Password:
Linux rpi3 4.14.0-3-arm64 #1 SMP Debian 4.14.12-2 (2018-01-06) aarch64
root@rpi3:~#

I'll look for a newer kernel.


I'm a bit confuse since I can boot a 4.19 kernel:

[0.00] Booting Linux on physical CPU 0x00 [0x410fd034]
[0.00] Linux version 4.19.0 (gokrazy@docker) (gcc version
6.3.0 20170516 (Debian 6.3.0-18)) #1 SMP PREEMPT Wed Mar 1 20:57:29
UTC 2017
[0.00] Machine model: Raspberry Pi 3 Model B
[0.00] earlycon: pl11 at MMIO 0x3f201000 (options '')
[0.00] bootconsole [pl11] enabled
...
[2.722577] Freeing unused kernel memory: 5696K
[2.723256] Run /init as init process
Loading, please wait...
starting version 236
...
root@rpi3:~# uname -a
Linux rpi3 4.19.0 #1 SMP PREEMPT Wed Mar 1 20:57:29 UTC 2017 aarch64 GNU/Linux



BTW I use these QEMU command line options while testing:

qemu-system-aarch64 \
   -d unimp,guest_errors \
   -trace bcm2835_cprman_rd_\* -trace bcm2835_cprman_wr_\* \
   ...

And the cmdline suggested by Peter:

   -append "rw earlycon=pl011,0x3f201000 console=ttyAMA0 loglevel=8
root=/dev/mmcblk0p2 fsck.repair=yes net.ifnames=0 rootwait memtest=1"

[1] 
https://translatedcode.wordpress.com/2018/04/25/debian-on-qemus-raspberry-pi-3-model/



[   45.683302] Run /sbin/init as init process


init is ran way after A2W register accesses, so I doubt they are the
problem here.

Can you provide me your testing setup?



-append 'earlycon=uart8250,mmio32,0x3f215040 rdinit=/sbin/init panic=-1 
console=ttyS1,115200'

On raspi3, ttyAMA0 can not be used as console because it is connected to 
something else.
I can boot if I use ttyAMA0 as console. Comparing the log output with the 
output when
using my original patch, tt looks like ttyS1 doesn't come up.

Hope this helps,
Guenter



Re: [Qemu-devel] [PATCH for 3.2 v2 0/7] hw/arm/bcm2835: Add basic support for cprman (clock subsystem)

2018-11-02 Thread Philippe Mathieu-Daudé
On Fri, Nov 2, 2018 at 8:32 AM Philippe Mathieu-Daudé  wrote:
>
> Hi Guenter,
>
> On Fri, Nov 2, 2018 at 3:52 AM Guenter Roeck  wrote:
> >
> > On 11/1/18 5:12 PM, Philippe Mathieu-Daudé wrote:
> > > Hi,
> > >
> > > This series is a mix of a previous work I had for the raspi, and a patch 
> > > from
> > > Guenter: 
> > > https://lists.gnu.org/archive/html/qemu-devel/2018-07/msg03153.html
> > >
> > > The final patch keep Guenter ideas and comments, but is mostly a rewrite.
> > > I dropped the A2W code from this work, it doesn't seems unuseful to me.
> > >
> > > Guenter can you test this series?
> > >
> >
> > arm/raspi2 works, but aarch64/raspi3 stalls.
>
> Thanks for testing it!
>
> So I suppose the A2W is required. And I'm probably using a too old kernel,
> I'm using the Buster preview following Peter's post [1]:
>
> [0.00] Linux version 4.14.0-3-arm64
> (debian-ker...@lists.debian.org) (gcc version 7.2.0 (Debian 7.2.0-18))
> #1 SMP Debian 4.14.12-2 (2018-01-06)
> [0.00] Machine model: Raspberry Pi 3 Model B
> [...]
> [8.044215] systemd[1]: Detected architecture arm64.
> Welcome to Debian GNU/Linux buster/sid!
>
> Debian GNU/Linux buster/sid rpi3 ttyAMA0
>
> rpi3 login: root
> Password:
> Linux rpi3 4.14.0-3-arm64 #1 SMP Debian 4.14.12-2 (2018-01-06) aarch64
> root@rpi3:~#
>
> I'll look for a newer kernel.

I'm a bit confuse since I can boot a 4.19 kernel:

[0.00] Booting Linux on physical CPU 0x00 [0x410fd034]
[0.00] Linux version 4.19.0 (gokrazy@docker) (gcc version
6.3.0 20170516 (Debian 6.3.0-18)) #1 SMP PREEMPT Wed Mar 1 20:57:29
UTC 2017
[0.00] Machine model: Raspberry Pi 3 Model B
[0.00] earlycon: pl11 at MMIO 0x3f201000 (options '')
[0.00] bootconsole [pl11] enabled
...
[2.722577] Freeing unused kernel memory: 5696K
[2.723256] Run /init as init process
Loading, please wait...
starting version 236
...
root@rpi3:~# uname -a
Linux rpi3 4.19.0 #1 SMP PREEMPT Wed Mar 1 20:57:29 UTC 2017 aarch64 GNU/Linux

>
> BTW I use these QEMU command line options while testing:
>
> qemu-system-aarch64 \
>   -d unimp,guest_errors \
>   -trace bcm2835_cprman_rd_\* -trace bcm2835_cprman_wr_\* \
>   ...
>
> And the cmdline suggested by Peter:
>
>   -append "rw earlycon=pl011,0x3f201000 console=ttyAMA0 loglevel=8
> root=/dev/mmcblk0p2 fsck.repair=yes net.ifnames=0 rootwait memtest=1"
>
> [1] 
> https://translatedcode.wordpress.com/2018/04/25/debian-on-qemus-raspberry-pi-3-model/
>
> >
> > [   45.683302] Run /sbin/init as init process

init is ran way after A2W register accesses, so I doubt they are the
problem here.

Can you provide me your testing setup?

Thanks,

Phil.

> > [   50.745961] random: dd: uninitialized urandom read (512 bytes read)
> > [   77.478266] Writes:  Total: 2074828  Max/Min: 0/0   Fail: 0
> >
> > ... then nothing else until I abort the session.
> >
> > This is with the series applied on top of master.
> >
> > Guenter
> >
> > > I kept Guenter S-o-b and (C), is that OK? (Guenter?, Peter?)
> > >
> > > - patches 1, 7: obvious updates in MAINTAINERS
> > > - patches 3, 4: simple cleanups
> > > - patches 2, 5: add UNIMP code
> > > - patch 6: add the cprman (KISS init values from Guenter)
> > >
> > > Peter: can you take patch #1 for 3.1?
> > >
> > > Regards,
> > >
> > > Phil.
> > >
> > > Philippe Mathieu-Daudé (7):
> > >MAINTAINERS: Add an entry for the Raspberry Pi machines
> > >hw/misc/bcm2835_property: Handle the 'domain state' property
> > >hw/arm/bcm2835: Use 0x prefix for hex numbers
> > >hw/arm/bcm2835: Rename some definitions
> > >hw/arm/bcm2835: Add various unimplemented peripherals
> > >hw/arm/bcm2835: Add basic support for cprman (clock subsystem)
> > >MAINTAINERS: Volunteer to review Raspi patches
> > >
> > >   MAINTAINERS  |   7 +
> > >   hw/arm/bcm2835_peripherals.c |  42 +++-
> > >   hw/char/bcm2835_aux.c|   2 +-
> > >   hw/intc/bcm2836_control.c|   4 +-
> > >   hw/misc/Makefile.objs|   1 +
> > >   hw/misc/bcm2835_cprman.c | 277 +++
> > >   hw/misc/bcm2835_property.c   |   8 +-
> > >   hw/misc/trace-events |   8 +
> > >   include/hw/arm/bcm2835_peripherals.h |  11 ++
> > >   include/hw/arm/raspi_platform.h  |   6 +-
> > >   include/hw/misc/bcm2835_cprman.h |  28 +++
> > >   11 files changed, 387 insertions(+), 7 deletions(-)
> > >   create mode 100644 hw/misc/bcm2835_cprman.c
> > >   create mode 100644 include/hw/misc/bcm2835_cprman.h
> > >
> >



Re: [Qemu-devel] [PATCH for 3.2 v2 0/7] hw/arm/bcm2835: Add basic support for cprman (clock subsystem)

2018-11-02 Thread Philippe Mathieu-Daudé
Hi Guenter,

On Fri, Nov 2, 2018 at 3:52 AM Guenter Roeck  wrote:
>
> On 11/1/18 5:12 PM, Philippe Mathieu-Daudé wrote:
> > Hi,
> >
> > This series is a mix of a previous work I had for the raspi, and a patch 
> > from
> > Guenter: https://lists.gnu.org/archive/html/qemu-devel/2018-07/msg03153.html
> >
> > The final patch keep Guenter ideas and comments, but is mostly a rewrite.
> > I dropped the A2W code from this work, it doesn't seems unuseful to me.
> >
> > Guenter can you test this series?
> >
>
> arm/raspi2 works, but aarch64/raspi3 stalls.

Thanks for testing it!

So I suppose the A2W is required. And I'm probably using a too old kernel,
I'm using the Buster preview following Peter's post [1]:

[0.00] Linux version 4.14.0-3-arm64
(debian-ker...@lists.debian.org) (gcc version 7.2.0 (Debian 7.2.0-18))
#1 SMP Debian 4.14.12-2 (2018-01-06)
[0.00] Machine model: Raspberry Pi 3 Model B
[...]
[8.044215] systemd[1]: Detected architecture arm64.
Welcome to Debian GNU/Linux buster/sid!

Debian GNU/Linux buster/sid rpi3 ttyAMA0

rpi3 login: root
Password:
Linux rpi3 4.14.0-3-arm64 #1 SMP Debian 4.14.12-2 (2018-01-06) aarch64
root@rpi3:~#

I'll look for a newer kernel.

BTW I use these QEMU command line options while testing:

qemu-system-aarch64 \
  -d unimp,guest_errors \
  -trace bcm2835_cprman_rd_\* -trace bcm2835_cprman_wr_\* \
  ...

And the cmdline suggested by Peter:

  -append "rw earlycon=pl011,0x3f201000 console=ttyAMA0 loglevel=8
root=/dev/mmcblk0p2 fsck.repair=yes net.ifnames=0 rootwait memtest=1"

[1] 
https://translatedcode.wordpress.com/2018/04/25/debian-on-qemus-raspberry-pi-3-model/

>
> [   45.683302] Run /sbin/init as init process
> [   50.745961] random: dd: uninitialized urandom read (512 bytes read)
> [   77.478266] Writes:  Total: 2074828  Max/Min: 0/0   Fail: 0
>
> ... then nothing else until I abort the session.
>
> This is with the series applied on top of master.
>
> Guenter
>
> > I kept Guenter S-o-b and (C), is that OK? (Guenter?, Peter?)
> >
> > - patches 1, 7: obvious updates in MAINTAINERS
> > - patches 3, 4: simple cleanups
> > - patches 2, 5: add UNIMP code
> > - patch 6: add the cprman (KISS init values from Guenter)
> >
> > Peter: can you take patch #1 for 3.1?
> >
> > Regards,
> >
> > Phil.
> >
> > Philippe Mathieu-Daudé (7):
> >MAINTAINERS: Add an entry for the Raspberry Pi machines
> >hw/misc/bcm2835_property: Handle the 'domain state' property
> >hw/arm/bcm2835: Use 0x prefix for hex numbers
> >hw/arm/bcm2835: Rename some definitions
> >hw/arm/bcm2835: Add various unimplemented peripherals
> >hw/arm/bcm2835: Add basic support for cprman (clock subsystem)
> >MAINTAINERS: Volunteer to review Raspi patches
> >
> >   MAINTAINERS  |   7 +
> >   hw/arm/bcm2835_peripherals.c |  42 +++-
> >   hw/char/bcm2835_aux.c|   2 +-
> >   hw/intc/bcm2836_control.c|   4 +-
> >   hw/misc/Makefile.objs|   1 +
> >   hw/misc/bcm2835_cprman.c | 277 +++
> >   hw/misc/bcm2835_property.c   |   8 +-
> >   hw/misc/trace-events |   8 +
> >   include/hw/arm/bcm2835_peripherals.h |  11 ++
> >   include/hw/arm/raspi_platform.h  |   6 +-
> >   include/hw/misc/bcm2835_cprman.h |  28 +++
> >   11 files changed, 387 insertions(+), 7 deletions(-)
> >   create mode 100644 hw/misc/bcm2835_cprman.c
> >   create mode 100644 include/hw/misc/bcm2835_cprman.h
> >
>



Re: [Qemu-devel] [PATCH for 3.2 v2 0/7] hw/arm/bcm2835: Add basic support for cprman (clock subsystem)

2018-11-01 Thread Guenter Roeck

On 11/1/18 5:12 PM, Philippe Mathieu-Daudé wrote:

Hi,

This series is a mix of a previous work I had for the raspi, and a patch from
Guenter: https://lists.gnu.org/archive/html/qemu-devel/2018-07/msg03153.html

The final patch keep Guenter ideas and comments, but is mostly a rewrite.
I dropped the A2W code from this work, it doesn't seems unuseful to me.

Guenter can you test this series?



arm/raspi2 works, but aarch64/raspi3 stalls.

[   45.683302] Run /sbin/init as init process
[   50.745961] random: dd: uninitialized urandom read (512 bytes read)
[   77.478266] Writes:  Total: 2074828  Max/Min: 0/0   Fail: 0

... then nothing else until I abort the session.

This is with the series applied on top of master.

Guenter


I kept Guenter S-o-b and (C), is that OK? (Guenter?, Peter?)

- patches 1, 7: obvious updates in MAINTAINERS
- patches 3, 4: simple cleanups
- patches 2, 5: add UNIMP code
- patch 6: add the cprman (KISS init values from Guenter)

Peter: can you take patch #1 for 3.1?

Regards,

Phil.

Philippe Mathieu-Daudé (7):
   MAINTAINERS: Add an entry for the Raspberry Pi machines
   hw/misc/bcm2835_property: Handle the 'domain state' property
   hw/arm/bcm2835: Use 0x prefix for hex numbers
   hw/arm/bcm2835: Rename some definitions
   hw/arm/bcm2835: Add various unimplemented peripherals
   hw/arm/bcm2835: Add basic support for cprman (clock subsystem)
   MAINTAINERS: Volunteer to review Raspi patches

  MAINTAINERS  |   7 +
  hw/arm/bcm2835_peripherals.c |  42 +++-
  hw/char/bcm2835_aux.c|   2 +-
  hw/intc/bcm2836_control.c|   4 +-
  hw/misc/Makefile.objs|   1 +
  hw/misc/bcm2835_cprman.c | 277 +++
  hw/misc/bcm2835_property.c   |   8 +-
  hw/misc/trace-events |   8 +
  include/hw/arm/bcm2835_peripherals.h |  11 ++
  include/hw/arm/raspi_platform.h  |   6 +-
  include/hw/misc/bcm2835_cprman.h |  28 +++
  11 files changed, 387 insertions(+), 7 deletions(-)
  create mode 100644 hw/misc/bcm2835_cprman.c
  create mode 100644 include/hw/misc/bcm2835_cprman.h






[Qemu-devel] [PATCH for 3.2 v2 0/7] hw/arm/bcm2835: Add basic support for cprman (clock subsystem)

2018-11-01 Thread Philippe Mathieu-Daudé
Hi,

This series is a mix of a previous work I had for the raspi, and a patch from
Guenter: https://lists.gnu.org/archive/html/qemu-devel/2018-07/msg03153.html

The final patch keep Guenter ideas and comments, but is mostly a rewrite.
I dropped the A2W code from this work, it doesn't seems unuseful to me.

Guenter can you test this series?

I kept Guenter S-o-b and (C), is that OK? (Guenter?, Peter?)

- patches 1, 7: obvious updates in MAINTAINERS
- patches 3, 4: simple cleanups
- patches 2, 5: add UNIMP code
- patch 6: add the cprman (KISS init values from Guenter)

Peter: can you take patch #1 for 3.1?

Regards,

Phil.

Philippe Mathieu-Daudé (7):
  MAINTAINERS: Add an entry for the Raspberry Pi machines
  hw/misc/bcm2835_property: Handle the 'domain state' property
  hw/arm/bcm2835: Use 0x prefix for hex numbers
  hw/arm/bcm2835: Rename some definitions
  hw/arm/bcm2835: Add various unimplemented peripherals
  hw/arm/bcm2835: Add basic support for cprman (clock subsystem)
  MAINTAINERS: Volunteer to review Raspi patches

 MAINTAINERS  |   7 +
 hw/arm/bcm2835_peripherals.c |  42 +++-
 hw/char/bcm2835_aux.c|   2 +-
 hw/intc/bcm2836_control.c|   4 +-
 hw/misc/Makefile.objs|   1 +
 hw/misc/bcm2835_cprman.c | 277 +++
 hw/misc/bcm2835_property.c   |   8 +-
 hw/misc/trace-events |   8 +
 include/hw/arm/bcm2835_peripherals.h |  11 ++
 include/hw/arm/raspi_platform.h  |   6 +-
 include/hw/misc/bcm2835_cprman.h |  28 +++
 11 files changed, 387 insertions(+), 7 deletions(-)
 create mode 100644 hw/misc/bcm2835_cprman.c
 create mode 100644 include/hw/misc/bcm2835_cprman.h

-- 
2.17.2