Re: [Qemu-devel] [PATCH v13 20/30] sdbus: add trace events

2018-05-04 Thread Peter Maydell
On 4 May 2018 at 17:11, Philippe Mathieu-Daudé wrote: > I went to the Coverity dashboard to update the Triage information but > the 'apply' box appears grey so I can not update those CIDs. You're only registered with Scan as a "Defect Viewer (read-only)". The Scan UI appears to be busted and does

Re: [Qemu-devel] [PATCH v13 20/30] sdbus: add trace events

2018-05-04 Thread Philippe Mathieu-Daudé
Hi Peter, Edgar, On 05/01/2018 06:03 AM, Peter Maydell wrote: > On 1 May 2018 at 04:35, Philippe Mathieu-Daudé wrote: >> On 04/30/2018 10:49 AM, Edgar E. Iglesias wrote: >>> On Fri, Apr 27, 2018 at 12:55:21PM +0100, Peter Maydell wrote: On 13 February 2018 at 04:07, Philippe Mathieu-Daudé

Re: [Qemu-devel] [PATCH v13 20/30] sdbus: add trace events

2018-05-01 Thread Peter Maydell
On 1 May 2018 at 04:35, Philippe Mathieu-Daudé wrote: > On 04/30/2018 10:49 AM, Edgar E. Iglesias wrote: >> On Fri, Apr 27, 2018 at 12:55:21PM +0100, Peter Maydell wrote: >>> On 13 February 2018 at 04:07, Philippe Mathieu-Daudé >>> wrote: Signed-off-by: Philippe Mathieu-Daudé Reviewed

Re: [Qemu-devel] [PATCH v13 20/30] sdbus: add trace events

2018-04-30 Thread Philippe Mathieu-Daudé
On 04/30/2018 10:49 AM, Edgar E. Iglesias wrote: > On Fri, Apr 27, 2018 at 12:55:21PM +0100, Peter Maydell wrote: >> On 13 February 2018 at 04:07, Philippe Mathieu-Daudé wrote: >>> Signed-off-by: Philippe Mathieu-Daudé >>> Reviewed-by: Alistair Francis >> >>> @@ -39,6 +45,7 @@ int sdbus_do_comma

Re: [Qemu-devel] [PATCH v13 20/30] sdbus: add trace events

2018-04-30 Thread Edgar E. Iglesias
On Fri, Apr 27, 2018 at 12:55:21PM +0100, Peter Maydell wrote: > On 13 February 2018 at 04:07, Philippe Mathieu-Daudé wrote: > > Signed-off-by: Philippe Mathieu-Daudé > > Reviewed-by: Alistair Francis > > > @@ -39,6 +45,7 @@ int sdbus_do_command(SDBus *sdbus, SDRequest *req, > > uint8_t *respo

Re: [Qemu-devel] [PATCH v13 20/30] sdbus: add trace events

2018-04-27 Thread Peter Maydell
On 13 February 2018 at 04:07, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Alistair Francis > @@ -39,6 +45,7 @@ int sdbus_do_command(SDBus *sdbus, SDRequest *req, uint8_t > *response) > { > SDState *card = get_card(sdbus); > > +trace_sdbus_comm

[Qemu-devel] [PATCH v13 20/30] sdbus: add trace events

2018-02-12 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis --- hw/sd/core.c | 14 -- hw/sd/trace-events | 5 + 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/hw/sd/core.c b/hw/sd/core.c index 295dc44ab7..498284f109 100644 --- a/hw/sd/core.c +++ b/